Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some Clippy warnings #5835

Merged
merged 9 commits into from
Jul 31, 2018
Merged

Resolve some Clippy warnings #5835

merged 9 commits into from
Jul 31, 2018

Commits on Jul 31, 2018

  1. Exempt 3 identity_op lint warnings

    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    4500704 View commit details
    Browse the repository at this point in the history

  2. Exempt too_many_arguments throughout the cargo lib crate 

    I'm confused.  Now this is duplicated with src/bin/cargo/main.rs and I
don't know how to avoid that.  Tips welcome.
    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    9c3f808 View commit details
    Browse the repository at this point in the history

  3. Resolve 2 needless_pass_by_value lint warnings 

    TIL Rust doesn't have equational reasoning.. :-/
(can't inline the new "exec" bindings)
    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    689f412 View commit details
    Browse the repository at this point in the history

  4. Resolve a wrong_self_convention lint warning 

    .. by inlining & removing `Members::is_empty`.

For details see
https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#wrong_self_convention

Asides from opt-ing out, the alternative I saw was calling it
"into_empty" and make it return a little

    enum Empty { Empty, NonEmpty }

type.
    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    1848645 View commit details
    Browse the repository at this point in the history

  5. Resolve a wrong_self_convention lint warning

    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    8947ed1 View commit details
    Browse the repository at this point in the history

  6. Resolve a trivially_copy_pass_by_ref lint warning

    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    a0a1ad6 View commit details
    Browse the repository at this point in the history

  7. Exempt 2 wrong_self_convention lint warnings

    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    a661b33 View commit details
    Browse the repository at this point in the history

  8. Resolve a single_match lint warning

    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    e55ecf9 View commit details
    Browse the repository at this point in the history

  9. Move all clippy config to target top files

    @dwijnand
    dwijnand committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    0807730 View commit details
    Browse the repository at this point in the history