Stop printing rustc command line if normally errored #5838
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
src/cargo/util/process_builder.rs
Outdated
| @@ -26,6 +26,9 @@ pub struct ProcessBuilder { | |||
| /// | |||
| /// [jobserver_docs]: https://docs.rs/jobserver/0.1.6/jobserver/ | |||
| jobserver: Option<Client>, | |||
| /// The status code which, if emitted, will prevent the output of the error | |||
| /// message containing the built command. | |||
| normal_error: Option<i32>, | |||
There was a problem hiding this comment.
Might be nicer to keep using ExitStatus here, rather than a raw i32.
There was a problem hiding this comment.
AFAICT there's no way to construct one
|
Thinking along the lines of @alexcrichton's comment in #5683 (the arch-rival to this PR), perhaps rather than do an exit code conditional thing the verbose output could be gated on |
|
That does sound like a mostly better idea -- I'll update this PR (and fix tests) soon. |
We used to print a wall of text especially in larger projects like the compiler, now we print a much smaller message. It's not generally useful to know the full compiler command anyway.
Mark-Simulacrum
force-pushed
the
short-output-normal-error
branch
from
993d0b5
to
91dd8df
Compare
|
Hm the intention for Cargo has always been that if |
|
Hm yes looks like this is actually a rustbuild bug. I'll look into it. |
We used to print a wall of text especially in larger projects like the
compiler, now we print a much smaller message. It's not generally useful
to know the full compiler command anyway.
Not completely sure this is the best place to have this, but seems to work in local testing.