Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for creating test dependencies. #5939

Merged
merged 1 commit into from
Aug 25, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Aug 24, 2018

Using Package has always been a little unclear to me. I think I understand
it now. Maybe this will help.

Using `Package` has always been a little unclear to me. I think I understand
it now. Maybe this will help.
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 25, 2018

📌 Commit d970d05 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 25, 2018

⌛ Testing commit d970d05 with merge dd3b70d...

bors added a commit that referenced this pull request Aug 25, 2018
Add documentation for creating test dependencies.

Using `Package` has always been a little unclear to me. I think I understand
it now. Maybe this will help.
@bors
Copy link
Contributor

bors commented Aug 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing dd3b70d to master...

@bors bors merged commit d970d05 into rust-lang:master Aug 25, 2018
@dwijnand
Copy link
Member

Wonderful @ehuss, thank you. Particularly for documenting the changes where I'd forgotten to. ♥️

@ehuss ehuss added this to the 1.30.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants