Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo fix --prepare-for should only apply edition fixes #5948

Closed

Conversation

dwijnand
Copy link
Member

Fixes #5738

.. or at least it looks like it does? Please check my test.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Thanks! I'm not sure though that this strategy will work because I believe the reported lint in the diagnostics is the lint in question (like async_idents) rather than the lint group (the compatibility lint group) unfortunately.

We may be able to tweak the compiler to tell us the lint group though!

@dwijnand
Copy link
Member Author

I think I see what you mean: see the fix::fix_overlapping failure in CI which says:

note: `-W absolute-paths-not-starting-with-crate` implied by `-W rust-2018-compatibility`

We may be able to tweak the compiler to tell us the lint group though!

Before you nerd-snipe me into the compiler repo, how maintainable is it to whitelist the list of lints implied by rust-*-compatibility?

@alexcrichton
Copy link
Member

Ah unfortunately the list of lints in rust-*-compatibility is changing over time pretty rapidly, so while it's possible in a pinch we could go with that strategy I'd personally prefer to avoid doing so.

AFAIK the issue here doesn't have a great solution that isn't invasive one way or another :(

@dwijnand
Copy link
Member Author

That's what I suspected/feared.

Is there an existing ticket in the rust repo for this? Do you think you (or @killercup, or...?) could flesh one out so I know how to get started? 🙏

@dwijnand dwijnand closed this Aug 29, 2018
@dwijnand dwijnand deleted the dont-fix-unrelated-warnings branch August 29, 2018 17:27
@alexcrichton
Copy link
Member

Ah unfortunately I don't thik there's an issue on the rust-lang/rust repo, and I wouldn't actually know where to get started for it :(

@killercup may have more ideas though!

bors added a commit that referenced this pull request Aug 29, 2018
…solve, r=alexcrichton

Extract FixArgs::prepare_for_edition_resolve

A little code dedup from working on #5948.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants