Stabilize -Zcompile-progress. #5995
Conversation
kennytm
force-pushed
the
stabilize-compile-progress
branch
from
a80b83a
to
b657f58
Compare
|
The error on stable and beta is legit. The rustdoc --color flag is stabilized by rust-lang/rust#53003, merged on Aug 5th, meaning it will only be present on 1.30+. I'll fix the error for nightly. |
|
✌️ @kennytm can now approve this pull request |
|
📌 Commit 595dbe6a292cf35874771704db9fe41ae180d266 has been approved by |
|
⌛ Testing commit 595dbe6a292cf35874771704db9fe41ae180d266 with merge c4d81d84eb5c06d0c709fb37e9800190b9159984... |
|
💔 Test failed - status-travis |
|
It looks like the tests are failing because rustdoc on stable/beta doesn't have the An alternative strategy is to do feature detection like we do with @kennytm do you have a preferred way to solve this? Or maybe @dwijnand as the now-expert on our test suite, do you have thoughts on this problem? |
|
One option, in the interim--as we roll this change out of cargo, while the underlying compiler change is still rolling out to stable, is to use |
|
I plan to execute |
|
@kennytm hm so one problem with that though is that it can slow down Cargo's execution time. Even running Are you thinking of just doing this in the test suite though? Or in Cargo itself? |
|
In cargo itself, call it once and then memorize the result (lazy_static it). I think this is needed beyond the test suite, eg targeting toolchains installed via bisection which normally won't download the corresponding cargo. |
|
Ah that's a good point. We'd definitely cache globally once in a process but I'm also worried about caching across Cargo invocations (where |
We detect this by executing `rustdoc --color never -V` and see if the result is successful. To avoid repeatedly creating a new process, we cache the result into `.rustc_info.json`.
kennytm
force-pushed
the
stabilize-compile-progress
branch
from
1a911a9
to
9597bce
Compare
|
Looks like this is green. Nice one! |
|
@bors r=alexcrichton |
|
📌 Commit 9597bce has been approved by |
Stabilize -Zcompile-progress. Closes #2536.
|
☀️ Test successful - status-appveyor, status-travis |
Remove rustdoc `can_add_color_process`. This was added in #5995 because at the time, earlier versions of rustdoc didn't support the flag, but those times have long since gone.
Closes #2536.