Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing messages when --message-format=json is deeply nested #6032

Closed
wants to merge 2 commits into from
Closed

Fix missing messages when --message-format=json is deeply nested #6032

wants to merge 2 commits into from

Commits on Sep 16, 2018

  1. Fix missing messages when --message-format=json is deeply nested 

    This commit demonstrates using miniserde for the JSON messages emitted
by machine_message::emit. Miniserde does not rely on recursion so this
approach supports messages with any arbitrarily large amount of nesting.

Pulling in a dependency on two different serialization libraries is not
ideal, especially as this one is generally more verbose and annoying as
a consequence of no recursion. We will need to discuss whether this
tradeoff makes sense or whether the bug can be resolved a different way.
    @dtolnay
    dtolnay committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    57ec068 View commit details
    Browse the repository at this point in the history

  2. Test deep recursion fix

    @dtolnay
    dtolnay committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    14a34d4 View commit details
    Browse the repository at this point in the history