Fix missing messages when --message-format=json is deeply nested #6081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches from serde_json::Value to RawValue, which can process arbitrarily deeply nested JSON content without recursion.
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit d1218d2 has been approved by |
|
⌛ Testing commit d1218d2 with merge 9189dabd083bc826ff66e7598582cbfd665c2168... |
|
💔 Test failed - status-appveyor |
|
@bors retry spurious windows changing_bin_paths_common_target_features_caches_targets |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Sep 24, 2018
Fix missing messages when --message-format=json is deeply nested This commit switches from `serde_json::Value` to [`RawValue`](https://docs.rs/serde_json/1.0/serde_json/value/struct.RawValue.html), which can process arbitrarily deeply nested JSON content without recursion. Fixes #5992. @ehuss
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches from
serde_json::ValuetoRawValue, which can process arbitrarily deeply nested JSON content without recursion.Fixes #5992. @ehuss