Second attempt at fixing msys terminal width. #6122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Lock the max width on msys-based terminals to 60. I tried a lot of different things, but I was unable to find a way to detect the correct width in mintty. Unfortunately this means that terminals that work correctly like ConEmu will also be capped at 60. C'est la vie. Of course this does not affect cmd, powershell, etc.
|
@bors: r+ |
|
📌 Commit 0503e34 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 3, 2018
Second attempt at fixing msys terminal width. Lock the max width on msys-based terminals to 60. I tried a lot of different things, but I was unable to find a way to detect the correct width in mintty. Unfortunately this means that terminals that work correctly like ConEmu will also be capped at 60. C'est la vie. Of course this does not affect cmd, powershell, etc. Fixes #6108
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock the max width on msys-based terminals to 60. I tried a lot of different
things, but I was unable to find a way to detect the correct width in mintty.
Unfortunately this means that terminals that work correctly like ConEmu will
also be capped at 60. C'est la vie.
Of course this does not affect cmd, powershell, etc.
Fixes #6108