-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure tar to not set mtime #6257
Conversation
Signed-off-by: Khionu Sybiern <dev@khionu.net>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Noted on Discord, the minimal-versions jobs failed because the |
Ok I've pushed 0.4.18 for |
Signed-off-by: Khionu Sybiern <dev@khionu.net>
@bors: r+ |
📌 Commit 5a59494 has been approved by |
⌛ Testing commit 5a59494 with merge b5462e609f53efd093f2d297d5680efcc79be5a1... |
💔 Test failed - status-travis |
flakey test |
Configure tar to not set mtime This PR is fixes #6238. Currently uses a `patch` on `tar`, and should not be merged until `tar` makes a release containing the function `set_preserve_mtime`.
☀️ Test successful - status-appveyor, status-travis |
This PR is fixes #6238. Currently uses a
patch
ontar
, and should not be merged untiltar
makes a release containing the functionset_preserve_mtime
.