Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardlink rmeta files. #6292

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Don't hardlink rmeta files. #6292

merged 1 commit into from
Nov 10, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 9, 2018

.rmeta files shouldn't be needed in the main directory, and since rustc started outputing rmeta files for binaries, there are name collisions between bins and libs of the same name.

Partial fix for #5524.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 9, 2018

📌 Commit 61f9588 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 9, 2018

⌛ Testing commit 61f9588 with merge 19eb6d6...

bors added a commit that referenced this pull request Nov 9, 2018
Don't hardlink rmeta files.

`.rmeta` files shouldn't be needed in the main directory, and since rustc started outputing rmeta files for binaries, there are name collisions between bins and libs of the same name.

Partial fix for #5524.
@bors
Copy link
Contributor

bors commented Nov 9, 2018

💔 Test failed - status-appveyor

@ehuss
Copy link
Contributor Author

ehuss commented Nov 9, 2018

@bors retry

@bors
Copy link
Contributor

bors commented Nov 9, 2018

⌛ Testing commit 61f9588 with merge f0950da...

bors added a commit that referenced this pull request Nov 9, 2018
Don't hardlink rmeta files.

`.rmeta` files shouldn't be needed in the main directory, and since rustc started outputing rmeta files for binaries, there are name collisions between bins and libs of the same name.

Partial fix for #5524.
@bors
Copy link
Contributor

bors commented Nov 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f0950da to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants