Support untyped warnings from registries with successful publish #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
carols10cents
changed the title
|
@bors: r+ This looks good to me, thanks! Is this something we should look to backport to get this onto stable more quickly? |
|
📌 Commit e66c413 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 12, 2018
…xcrichton Support untyped warnings from registries with successful publish This adds a field "other" to the warnings deserialized from a successful publish response from a registry. This is [part of our plan to eventually require an email address to publish on crates.io to comply with DMCA](rust-lang/crates-io-cargo-teams#8). The TL;DR of that is we plan to warn for a release cycle when you publish without a verified email address once this change makes it to stable. I'm opting to add an "other" field rather than another field like the invalid badges/categories fields for a few reasons: - The warning we're planning on adding about emails will only exist for 6 weeks; those other warnings have happened in the past and will continue to happen. - There may be other transient warnings on publish that we'd like to send from crates.io in the future; it'd be nice to have a way of doing that without having to update cargo as well. - Other registries may have different warnings than we could ever anticipate in cargo; if usage of alternate registries grows, it'd be nice to give them a mechanism to warn as well. I've tested: - Cargo compiled with this change against a crates.io instance that doesn't return `other` warnings - Cargo compiled with this change against a crates.io instance that DOES return `other` warnings - Current Cargo against a crates.io instance that does return `other` warnings and they all behaved as I expected. I haven't added any tests because there aren't any tests that inject registry responses, and while I think cargo should have some of those eventually, I'm not going to add that infrastructure without discussing it with lots of folks first :) I know there's a soft feature freeze right now, buuuuut [it's wafer thin](https://proxy.duckduckgo.com/iu/?u=https%3A%2F%2Fs4.thcdn.com%2Fproductimg%2F0%2F600%2F600%2F27%2F10284327-1288263770-74000.jpg&f=1)!! It doesn't add any surface area to the CLI or manifest format! ❤️
|
☀️ Test successful - status-appveyor, status-travis |
|
It's up to you. We've been talking about how we need to do this for over a
year, so there's not any particular rush other than making sure it actually
happens eventually.
…On Mon, Nov 12, 2018, 3:42 PM bors ***@***.*** wrote:
Merged #6303 <#6303> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6303 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAL1UvncPi_CIUVfbQg1PmZsVQ2MiYRkks5uuccSgaJpZM4YYsKc>
.
|
|
Ah ok, in that case I think we'll let this one ride the trains |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a field "other" to the warnings deserialized from a successful publish response from a registry.
This is part of our plan to eventually require an email address to publish on crates.io to comply with DMCA. The TL;DR of that is we plan to warn for a release cycle when you publish without a verified email address once this change makes it to stable.
I'm opting to add an "other" field rather than another field like the invalid badges/categories fields for a few reasons:
I've tested:
otherwarningsotherwarningsotherwarningsand they all behaved as I expected.
I haven't added any tests because there aren't any tests that inject registry responses, and while I think cargo should have some of those eventually, I'm not going to add that infrastructure without discussing it with lots of folks first :)
I know there's a soft feature freeze right now, buuuuut it's wafer thin!! It doesn't add any surface area to the CLI or manifest format! ❤️