Enable the zlib feature of flate2
#6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're already pulling in zlib for other dependencies like curl/libgit2 so there's not really much use in duplicating the compression code with miniz, so let's instruct `flate2` to use libz as well to compress and decompress chunks.
|
SGTM! @bors: r+ |
|
📌 Commit d9eca8c has been approved by |
bors
added a commit
that referenced
this pull request
Nov 14, 2018
Enable the `zlib` feature of `flate2` We're already pulling in zlib for other dependencies like curl/libgit2 so there's not really much use in duplicating the compression code with miniz, so let's instruct `flate2` to use libz as well to compress and decompress chunks.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already pulling in zlib for other dependencies like curl/libgit2
so there's not really much use in duplicating the compression code with
miniz, so let's instruct
flate2to use libz as well to compress anddecompress chunks.