Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extern crate usage in custom build #6423

Conversation

dwijnand
Copy link
Member

Is this needed? Let's find out together.

@rust-highfive
Copy link

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc
Copy link
Member

nrc commented Dec 13, 2018

Travis seems to be looping in workspaces::you_cannot_generate_lockfile_for_empty_workspaces

@ehuss
Copy link
Contributor

ehuss commented Dec 13, 2018

It's actually metabuild_json_artifact which is hanging.

Metabuild was intentionally written at the time to use 2015. If you want to switch it, Target::metabuild_target would need to be changed, though I don't see a reason to.

The hang reveals several bugs, though:

  • If metabuild ever fails to build, it generates a message that causes a panic. This should be fixed. I'll try to look at that.
  • In some cases, when Cargo panics while processing a job, it hangs forever. I've noticed this in the past, I'll file an issue and look at what it takes to fix.

@dwijnand
Copy link
Member Author

Interesting. Thank you both.

@dwijnand dwijnand closed this Dec 13, 2018
@dwijnand dwijnand deleted the remove-extern-crate-usage-in-custom-build branch December 13, 2018 07:39
bors added a commit that referenced this pull request Dec 17, 2018
…ehuss

Upgrade the metabuild to Rust 2018

Just happened across the code that @ehuss mentioned in #6423 (comment) and thought of reviving that effort.

@ehuss says there's no reason to.  Let's see if it passes CI and we should land this change or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants