Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --target HOST alias for host target #6777

Closed
wants to merge 2 commits into from

Conversation

phil-opp
Copy link
Contributor

@phil-opp phil-opp commented Mar 23, 2019

This adds a HOST alias for the host target. It is useful when the default target is overridden in a .cargo/config file. It provides a platform-independent way to reset the target back to the host target. See #6775 for more motivation.

Closes #6775

This alias is useful when the default target is overridden in a `.cargo/config` file. It provides a platform-independent way to reset the target back to the host target.
@rust-highfive
Copy link

r? @dwijnand

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2019
@dwijnand
Copy link
Member

r? @alexcrichton

@alexcrichton
Copy link
Member

Thanks for the PR and sorry for the delay!

I'm not personally convinced that we would want this feature, but others can of course voice their thoughts too! The semantics here aren't actually quite right where for various reasons --target $host is different than not passing --target at all. I also think that this is something that is pretty big (aliases for targets) and would need to be carefully considered in the context of everything that consumes targets in Rust (where everything takes opaque strings rather than being ready to handle aliases)

@phil-opp
Copy link
Contributor Author

phil-opp commented Apr 1, 2019

Thanks for the PR and sorry for the delay!

No worries, thanks for reviewing!

The semantics here aren't actually quite right where for various reasons --target $host is different than not passing --target at all. I also think that this is something that is pretty big (aliases for targets) and would need to be carefully considered in the context of everything that consumes targets in Rust (where everything takes opaque strings rather than being ready to handle aliases)

Ok, makes sense. It seemed like a small addition, but I now see that it is more complicated than that. I think there are better solutions to my problem (for example #6784), so I'm gonna close this PR and #6775 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants