-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish-lockfile: Various updates #6840
Commits on Apr 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ebb5764 - Browse repository at this point
Copy the full SHA ebb5764View commit details -
publish-lockfile: Always check Cargo.lock is up-to-date.
This changes it so that `cargo package` will make sure the Cargo.lock file is in sync with the Cargo.toml that is generated during packaging. This has several points: - This makes the Cargo.lock more accurately reflect what would be locked if a user runs `cargo install` on the resulting package. - In a workspace, this removes irrelevant packages from the lock file. - This handles `[patch]` dependencies and dual-source dependencies (like path/version). - Warnings are generated for any differences in the lock file compared to the original. This has a significant change in how `cargo package` works. It now unconditionally copies the package to `target/package`. Previously this was only done during the verification step. This is necessary to run the resolver against the new `Cargo.toml` that gets generated.
Configuration menu - View commit details
-
Copy full SHA for 27932ea - Browse repository at this point
Copy the full SHA 27932eaView commit details -
cargo install: Ignore Cargo.lock for non --path installs.
Requires `--locked` to use Cargo.lock for registry and git installs.
Configuration menu - View commit details
-
Copy full SHA for 3d89379 - Browse repository at this point
Copy the full SHA 3d89379View commit details -
Add warnings for yanked dependencies.
This only applies for `cargo package/publish` with the publish-lockfile feature, or `cargo install --locked`.
Configuration menu - View commit details
-
Copy full SHA for 5f616eb - Browse repository at this point
Copy the full SHA 5f616ebView commit details -
publish-lockfile: Change default to
true
.The feature still needs to be enabled.
Configuration menu - View commit details
-
Copy full SHA for c03c85a - Browse repository at this point
Copy the full SHA c03c85aView commit details -
Configuration menu - View commit details
-
Copy full SHA for eae8900 - Browse repository at this point
Copy the full SHA eae8900View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eb55ab - Browse repository at this point
Copy the full SHA 6eb55abView commit details -
cargo publish: Revert back to extracting tar file.
This constructs the new Cargo.lock in memory instead of writing it directly to disk. The in-memory copy is added to the tar file directly.
Configuration menu - View commit details
-
Copy full SHA for 9328b12 - Browse repository at this point
Copy the full SHA 9328b12View commit details -
Alter
cargo package
Cargo.lock modification note.Try to make it clearer that it is not modifying the actual Cargo.lock file, but the one that is being stored in the .crate file.
Configuration menu - View commit details
-
Copy full SHA for 753b03f - Browse repository at this point
Copy the full SHA 753b03fView commit details -
This also restores the Cargo.lock update during packaging.
Configuration menu - View commit details
-
Copy full SHA for 5553284 - Browse repository at this point
Copy the full SHA 5553284View commit details -
Remove
source
from compile_ws.This was added for `cargo install` to avoid updating the source multiple times. Now that multiple updates are guarded via `Config::updated_sources`, it is no longer necessary.
Configuration menu - View commit details
-
Copy full SHA for 8a30158 - Browse repository at this point
Copy the full SHA 8a30158View commit details
Commits on Apr 17, 2019
-
Include Cargo.lock in package checks.
This includes `Cargo.lock` in the git dirty check. It explicitly excludes `Cargo.lock` as an untracked file, since it is not relevant for the dirty check; it is only checked if it is committed to git. This also adds `Cargo.lock` to the "did anything modify this" check during verification. I don't see a reason to exclude it (particularly since ephemeral workspaces do not save the lock file). Also add "Archiving: Cargo.lock" to the verbose output.
Configuration menu - View commit details
-
Copy full SHA for 7d20230 - Browse repository at this point
Copy the full SHA 7d20230View commit details