Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: Suggest --lib option as binary template now the default #6926

Merged
merged 1 commit into from
May 12, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented May 10, 2019

r? @ehuss

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2019
@tesuji
Copy link
Contributor Author

tesuji commented May 10, 2019

r? @joshtriplett , to free assign log from ehuss

@rust-highfive rust-highfive assigned joshtriplett and unassigned ehuss May 10, 2019
@ehuss
Copy link
Contributor

ehuss commented May 12, 2019

Thanks, I think Josh has been traveling. I wouldn't put too much effort into updating the completions, since they are quite old and I intend to replace them soonish.

@bors r+

@bors
Copy link
Contributor

bors commented May 12, 2019

📌 Commit c71bd22 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2019
@bors
Copy link
Contributor

bors commented May 12, 2019

⌛ Testing commit c71bd22 with merge 9634a3a...

bors added a commit that referenced this pull request May 12, 2019
zsh: Suggest --lib option as binary template now the default

r? @ehuss
@bors
Copy link
Contributor

bors commented May 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: ehuss
Pushing 9634a3a to master...

@bors bors merged commit c71bd22 into rust-lang:master May 12, 2019
@tesuji tesuji deleted the cargo-new-zshcomp branch May 13, 2019 02:29
bors added a commit to rust-lang/rust that referenced this pull request May 16, 2019
Update cargo

17 commits in 759b6161a328db1d4863139e90875308ecd25a75..c4fcfb725b4be00c72eb9cf30c7d8b095577c280
2019-05-06 20:47:49 +0000 to 2019-05-15 19:48:47 +0000
- tests: registry: revert readonly permission after running tests. (rust-lang/cargo#6947)
- Remove Candidate (rust-lang/cargo#6946)
- Fix for "Running cargo update without a Cargo.lock ignores arguments" rust-lang/cargo#6872 (rust-lang/cargo#6904)
- Fix a minor mistake in the changelog. (rust-lang/cargo#6944)
- Give a better error message when crates.io requests time out (rust-lang/cargo#6936)
- Re-enable compatibility with readonly CARGO_HOME (rust-lang/cargo#6940)
- Fix version of `ignore`. (rust-lang/cargo#6938)
- Stabilize offline mode. (rust-lang/cargo#6934)
- zsh: Add doc options to include non-public items documentation (rust-lang/cargo#6929)
- zsh: Suggest --lib option as binary template now the default (rust-lang/cargo#6926)
- Migrate package include/exclude to gitignore patterns. (rust-lang/cargo#6924)
- Implement the Cargo half of pipelined compilation (take 2) (rust-lang/cargo#6883)
- Always include `Cargo.toml` when packaging. (rust-lang/cargo#6925)
- Remove unnecessary calls to masquerade_as_nightly_cargo. (rust-lang/cargo#6923)
- download: fix "Downloaded 1 crates" message (crates -> crate) (rust-lang/cargo#6920)
- Changed RUST_LOG usage to CARGO_LOG to avoid confusion. (rust-lang/cargo#6918)
- crate download: don't print that a crate was the largest download if it was the only download (rust-lang/cargo#6916)
@ehuss ehuss added this to the 1.36.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants