Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support target configuration in workspace modules #7022

Closed
wants to merge 4 commits into from
Closed

WIP: Support target configuration in workspace modules #7022

wants to merge 4 commits into from

Conversation

j16r
Copy link

@j16r j16r commented Jun 8, 2019

[Fixes #7004]

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2019
@bors
Copy link
Collaborator

bors commented Jul 10, 2019

☔ The latest upstream changes (presumably #7116) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Sep 16, 2019

☔ The latest upstream changes (presumably #7350) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

This has unfortunately been languishing for quite some time now so I'm gonna go ahead and close this. In general we'd reocmmend discussing design and sending a PR once the team is good to go on a new feature, unfortunately starting with failing tests tends to not have a ton of traction :(

@autodidaddict
Copy link

Does this mean that Cargo still completely ignores the .cargo/config files in each of the sub-directories? Because this is still a pretty nasty problem that prevents me from running a cargo build on the entire workspace.

@j16r
Copy link
Author

j16r commented Nov 4, 2019

I don't believe it completely ignores .cargo/config, only the target triple

@autodidaddict
Copy link

autodidaddict commented Nov 4, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per crate build target in workspace
5 participants