Clean environment when git-fetch-with-cli is used. #7082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Just my two cents, wouldn't it be overkill to clear the entire environment before executing the git cli? As cargo uses the cli for a very specific purpose, noone has any business setting any env-flags anyway. SSH maybe? |
|
I thought about that, but I think there are various curl and ssh environment variables that should be kept. It seemed like a remove-list would be easier to maintain than an allow-list. |
|
@bors r+ |
|
📌 Commit 00fd31d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 29, 2019
Clean environment when git-fetch-with-cli is used. When the GIT_DIR environment variable is set, git-the-cli will use that instead of looking at cwd. This can happen, for example, when using the `exec` command in `git rebase` to call cargo. This causes cargo to fetch into the wrong directory. Closes #7072
|
☀️ Test successful - checks-travis, status-appveyor |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 10, 2019
Update cargo Update cargo 12 commits in 4c1fa54d10f58d69ac9ff55be68e1b1c25ecb816..677a180f4c8ca1dcef594f68dd0e63e4f08621f5 2019-06-24 11:24:18 +0000 to 2019-07-08 13:43:02 +0000 - Update dependencies (rust-lang/cargo#7106) - Fix overwriting .d file for binary with dSYM on apple targets. (rust-lang/cargo#7057) - Update changelog. (rust-lang/cargo#7102) - Revert "Fix 'getting started' internal links" (rust-lang/cargo#7099) - Bump to 0.39.0 (rust-lang/cargo#7100) - Update dependency.rs (rust-lang/cargo#7098) - Typo (rust-lang/cargo#7097) - Fix 'getting started' internal links (rust-lang/cargo#7093) - Fix misleading comment in testsuite (rust-lang/cargo#7090) - improve uncommitted changes cargo-package message (rust-lang/cargo#7083) - Clean environment when git-fetch-with-cli is used. (rust-lang/cargo#7082) - Fix exponentiality in depend_on_deps_of_deps. (rust-lang/cargo#7062)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the GIT_DIR environment variable is set, git-the-cli will use that instead of looking at cwd. This can happen, for example, when using the
execcommand ingit rebaseto call cargo. This causes cargo to fetch into the wrong directory.Closes #7072