Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update two tests for changes in rustc output #7231

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

petrochenkov
Copy link
Contributor

Required for landing rust-lang/rust#63250.

(I'm not sure what is the process for landing synchronous changes like this.)

@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2019
@alexcrichton
Copy link
Member

The easiest thing here is probably to relax the assertion by changing module to [..], and that should pass on both I think?

@petrochenkov
Copy link
Contributor Author

Updated with [..] instead of crate.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 9, 2019

📌 Commit 6959316 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2019
@bors
Copy link
Contributor

bors commented Aug 9, 2019

⌛ Testing commit 6959316 with merge e853aa9...

bors added a commit that referenced this pull request Aug 9, 2019
Update two tests for changes in rustc output

Required for landing rust-lang/rust#63250.

(I'm not sure what is the process for landing synchronous changes like this.)
@bors
Copy link
Contributor

bors commented Aug 9, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing e853aa9 to master...

@bors bors merged commit 6959316 into rust-lang:master Aug 9, 2019
@ehuss
Copy link
Contributor

ehuss commented Aug 10, 2019

@petrochenkov Feel free to update the cargo submodule in your PR if you think it will get merged within the next week or so. Or if you'd prefer, I can post an update PR, but you'll have to wait for it to make its way through the bors queue. Just let me know.

@ehuss ehuss added this to the 1.38.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants