Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hang when Cargo's worker threads panic #7366

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

alexcrichton
Copy link
Member

This shouldn't ever happen during normal development, but happens from
time to time while developing Cargo itself.

Closes #6433

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2019
@Eh2406
Copy link
Contributor

Eh2406 commented Sep 16, 2019

fmt then it looks ok to me

This shouldn't ever happen during normal development, but happens from
time to time while developing Cargo itself.

Closes rust-lang#6433
@alexcrichton
Copy link
Member Author

@bors: r=Eh2406

@bors
Copy link
Collaborator

bors commented Sep 16, 2019

📌 Commit 8a3c0fe has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2019
@bors
Copy link
Collaborator

bors commented Sep 16, 2019

⌛ Testing commit 8a3c0fe with merge bcb89d1...

bors added a commit that referenced this pull request Sep 16, 2019
Don't hang when Cargo's worker threads panic

This shouldn't ever happen during normal development, but happens from
time to time while developing Cargo itself.

Closes #6433
@bors
Copy link
Collaborator

bors commented Sep 16, 2019

☀️ Test successful - checks-azure
Approved by: Eh2406
Pushing bcb89d1 to master...

@bors bors merged commit 8a3c0fe into rust-lang:master Sep 16, 2019
@alexcrichton alexcrichton deleted the fix-hang branch September 17, 2019 16:01
@ehuss ehuss added this to the 1.39.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in Job causes Cargo to hang indefinitely.
5 participants