-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate towards exclusively using serde for Config
#7456
Commits on Oct 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 022814d - Browse repository at this point
Copy the full SHA 022814dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f73320 - Browse repository at this point
Copy the full SHA 0f73320View commit details -
Refactor
ConfigKey
to its own fileAlso make it a little less allocation-heavy by tweaking the API to encourage incremental building of the key and incremental destruction as we walk throughout the configuration tree.
Configuration menu - View commit details
-
Copy full SHA for c0baf84 - Browse repository at this point
Copy the full SHA c0baf84View commit details -
Finish implementing
Value
, use it in helpersRewrite helpers like `get_bool` to use `get::<Option<Value<bool>>>` instead of duplicating the logic that's already with the typed access of configuration. This is more along the effort to centralize all deserialization of configuration into typed values instead of using ad-hoc accessors in a number of locations.
Configuration menu - View commit details
-
Copy full SHA for 37ace88 - Browse repository at this point
Copy the full SHA 37ace88View commit details -
This callsite doesn't need the full power of `get_list`, knowing the definition path of each element along the list.
Configuration menu - View commit details
-
Copy full SHA for 5bba426 - Browse repository at this point
Copy the full SHA 5bba426View commit details -
Centralize HTTP configuration in one struct
Gives us one nice place to access and document all HTTP-related configuration
Configuration menu - View commit details
-
Copy full SHA for 2357bb0 - Browse repository at this point
Copy the full SHA 2357bb0View commit details -
Access
term
config through a deserialized typeGoing through and removing users of raw `get_*` functions!
Configuration menu - View commit details
-
Copy full SHA for cbda532 - Browse repository at this point
Copy the full SHA cbda532View commit details -
Consolidate
net
configuration into a typed structureLess need for `get_bool` and friends!
Configuration menu - View commit details
-
Copy full SHA for 8d65906 - Browse repository at this point
Copy the full SHA 8d65906View commit details -
Configuration menu - View commit details
-
Copy full SHA for a458cd8 - Browse repository at this point
Copy the full SHA a458cd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09d9165 - Browse repository at this point
Copy the full SHA 09d9165View commit details -
Consolidate
build
key configurationAdd a typed structure which lists all `build` key configuration throughout Cargo.
Configuration menu - View commit details
-
Copy full SHA for d7d8ca1 - Browse repository at this point
Copy the full SHA d7d8ca1View commit details -
Simplify
cargo-new
configuration readingNo need for lots of extra helpers/parsing when using serde!
Configuration menu - View commit details
-
Copy full SHA for 44a31d6 - Browse repository at this point
Copy the full SHA 44a31d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe7b5fc - Browse repository at this point
Copy the full SHA fe7b5fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a6cd74 - Browse repository at this point
Copy the full SHA 3a6cd74View commit details -
Configuration menu - View commit details
-
Copy full SHA for dab42bb - Browse repository at this point
Copy the full SHA dab42bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0d94ff - Browse repository at this point
Copy the full SHA a0d94ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a9a46e - Browse repository at this point
Copy the full SHA 0a9a46eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2387e1a - Browse repository at this point
Copy the full SHA 2387e1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0667f5 - Browse repository at this point
Copy the full SHA e0667f5View commit details
Commits on Oct 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9a12e48 - Browse repository at this point
Copy the full SHA 9a12e48View commit details