Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for cyclic dependencies #7470

Merged
merged 1 commit into from
Oct 8, 2019

Commits on Oct 7, 2019

  1. Improve error message for cyclic dependencies

    First reported in rust-lang/rust#65014 it looks like our error message
    on cyclic dependencies may be confusing at times. It looks like this is
    an issue because there are multiple paths through a graph for a
    dependency, so using the generic `path_to_top` function isn't producing
    the most useful path for this purpose.
    
    We're already walking the graph though, so this commit adds an extra
    parameter which collects the list of packages we've visited so far to
    produce a hopefully always-accurate error message showing the chain of
    dependencies end-to-end for what depends on what.
    alexcrichton committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    a92fd48 View commit details
    Browse the repository at this point in the history