Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a broken link in CONTRIBUTING.md #7644

Closed
wants to merge 1 commit into from
Closed

Fix a broken link in CONTRIBUTING.md #7644

wants to merge 1 commit into from

Conversation

giraffate
Copy link
Contributor

testsuite/support/mod.rs is replaced at 9115b2c.

In #7632, CI timed out continues. This time-out seems to be related [ci skip] in commit message.
So, I remove this [ci skip]. If CI passes, #7632 will be closed.

@giraffate
Fix a broken link in CONTRIBUTING.md
50e1ff8 
`testsuite/support/mod.rs` is replaced at 9115b2c.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2019
@alexcrichton
Copy link
Member

@bors: r+

Oops, thanks!

@bors
Copy link
Contributor

bors commented Dec 2, 2019

📌 Commit 50e1ff8 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2019
@bors
Copy link
Contributor

bors commented Dec 2, 2019

⌛ Testing commit 50e1ff8 with merge 64b87807d1f2ae917d8ff4db092ff53d3952c4c9...

@ehuss
Copy link
Contributor

ehuss commented Dec 2, 2019

@bors r-
I think it is still skipping.

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 2, 2019
@bors
Copy link
Contributor

bors commented Dec 2, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Dec 2, 2019
@bors
Copy link
Contributor

bors commented Dec 2, 2019

☔ The latest upstream changes (presumably #7642) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss
Copy link
Contributor

ehuss commented Dec 2, 2019

This got rolled up in #7642. 😃

@ehuss ehuss closed this Dec 2, 2019
@giraffate giraffate deleted the fix_the_broken_link branch December 3, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giraffate @rust-highfive @alexcrichton @bors @ehuss