Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid buffering large amounts of rustc output. #7838

Merged
merged 4 commits into from
Mar 12, 2020
Merged

Avoid buffering large amounts of rustc output. #7838

merged 4 commits into from
Mar 12, 2020

Commits on Mar 7, 2020

  1. Replace std::sync::mpsc with a much simpler queue 

    We don't need the complexity of most channels since this is not a
performance sensitive part of Cargo, nor is it likely to be so any time
soon. Coupled with recent bugs (rust-lang#7840) we believe in `std::sync::mpsc`,
let's just not use that and use a custom queue type locally which should
be amenable to a blocking push soon too.
    @alexcrichton @ehuss
    alexcrichton authored and ehuss committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    458138b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2020

  1. Avoid buffering large amounts of rustc output.

    @ehuss
    ehuss committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    e2b28f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Add test for caching large output.

    @ehuss
    ehuss committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    c67cd7a View commit details
    Browse the repository at this point in the history

  2. Use wait_while for Condvar in Queue to simplify code.

    @ehuss
    ehuss committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    05a1f43 View commit details
    Browse the repository at this point in the history