Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some extra fingerprint debug information. #7888

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 16, 2020

There have been some situations where the existing log info was not sufficient to understand the cause of a rebuild. I hope that this additional information can help with debugging problems.

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2020
@Eh2406
Copy link
Contributor

Eh2406 commented Feb 16, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Feb 16, 2020

📌 Commit 677b24a has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2020
@bors
Copy link
Contributor

bors commented Feb 16, 2020

⌛ Testing commit 677b24a with merge 1492e57...

bors added a commit that referenced this pull request Feb 16, 2020
Add some extra fingerprint debug information.

There have been some situations where the existing log info was not sufficient to understand the cause of a rebuild.  I hope that this additional information can help with debugging problems.
@bors
Copy link
Contributor

bors commented Feb 16, 2020

☀️ Test successful - checks-azure
Approved by: Eh2406
Pushing 1492e57 to master...

@bors bors merged commit 677b24a into rust-lang:master Feb 16, 2020
bors added a commit that referenced this pull request Feb 16, 2020
Add new/old rustflags to fingerprint log.

Follow up to #7888. Due to a conversation with someone I had with Discord who was having trouble determining why something was rebuilding.
bors added a commit to rust-lang/rust that referenced this pull request Feb 19, 2020
Update cargo

9 commits in 3c53211c3d7fee4f430f170115af5baad17a3da9..e02974078a692d7484f510eaec0e88d1b6cc0203
2020-02-07 15:35:03 +0000 to 2020-02-18 15:24:43 +0000
- Set an environment variable for tests to find executables. (rust-lang/cargo#7697)
- Rework internal errors. (rust-lang/cargo#7896)
- Improvements to StringList config handling. (rust-lang/cargo#7891)
- Add new/old rustflags to fingerprint log. (rust-lang/cargo#7890)
- Fix inaccurate doc comment on `env_args`. (rust-lang/cargo#7889)
- Add some extra fingerprint debug information. (rust-lang/cargo#7888)
- Link the licenses into crates/cargo-platform (rust-lang/cargo#7886)
- Modify test to make `rustc` PR mergeable (rust-lang/cargo#7883)
- Keep environment variables in a BTreeMap to preserve sort order (rust-lang/cargo#7877)
bors added a commit that referenced this pull request Mar 2, 2020
…hton

Add more fingerprint mtime debug logging.

Adding some more debug logging on top of #7888.

There was a mistake in the original PR, where `dep.pkg_id` should have been `dep.name`.
@ehuss ehuss added this to the 1.43.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants