Add an option to include crate versions to the generated docs #7903
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Looks great! Can you add a section to the bottom of |
aleksator
force-pushed
the
1681_doc_crate_version
branch
from
8f9ec0f
to
ad53938
Compare
Thank you! I have added it as a separate commit (please indicate if you would prefer it squashed), linked to the issue and rebased the branch on master. |
|
☔ The latest upstream changes (presumably #7820) made this pull request unmergeable. Please resolve the merge conflicts. |
aleksator
force-pushed
the
1681_doc_crate_version
branch
from
ad53938
to
fc5e17a
Compare
|
Thanks! A separate commit is probably fine, I normally only squash if there are a bunch of commits, or commits are changing previous ones in the same PR. @rust-lang/cargo FYI, this is a really minor new nightly-only feature, so I'm not going to bother with FCP. If there are changes (or if we think we should never do this), feel free to leave comments on the tracking issue. @bors r+ |
|
📌 Commit fc5e17a has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit fc5e17a with merge bcc82b10c8097f51d56b95063c77a9646130fed7... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Update cargo 11 commits in e02974078a692d7484f510eaec0e88d1b6cc0203..e57bd02999c9f40d52116e0beca7d1dccb0643de 2020-02-18 15:24:43 +0000 to 2020-02-21 20:20:10 +0000 - fix most remaining clippy findings (mostly redundant imports) (rust-lang/cargo#7912) - Add -Zfeatures tracking issues. (rust-lang/cargo#7917) - Use rust-lang/rust linkchecker on CI. (rust-lang/cargo#7913) - Clean up code mostly based on clippy suggestions (rust-lang/cargo#7911) - Add an option to include crate versions to the generated docs (rust-lang/cargo#7903) - Better support for license-file. (rust-lang/cargo#7905) - Add new feature resolver. (rust-lang/cargo#7820) - Switch azure to macOS 10.15. (rust-lang/cargo#7906) - Modified the help information of cargo-rustc (rust-lang/cargo#7892) - Update for nightly rustfmt. (rust-lang/cargo#7904) - Support `--config path_to_config.toml` cli syntax. (rust-lang/cargo#7901)
Fixes #1681