-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-std: Don't treat std like a "local" package. #8177
Conversation
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
I heavily considered the approach suggested in rust-lang/wg-cargo-std-aware#44 (comment) to add a field to Also, I'm totally up for using a different phrase than "local", open to suggestions! |
@bors: r+ Nah this looks good to me. Thanks for this! |
📌 Commit b6a4b07 has been approved by |
☀️ Test successful - checks-azure |
Fix dep-info files including non-local build script paths. I derped in #8177 and accidentally used the wrong unit when iterating over the dependencies when writing the `.d` file. The consequence here is that all the `rerun-if-changed` paths from a unit's dependencies are included in the `.d` file. This fixes it so that it does not include non-local dependencies. Fixes #9445
This changes it so that build-std will not treat the std crates like a "local" package. This has the following changes:
.d
dep-info file does not include std crate sources.Closes rust-lang/wg-cargo-std-aware#44
Closes rust-lang/wg-cargo-std-aware#55