Rephrased error message for disallowed sections in virtual workspace

[Julian-Wollersberger]

I changed the error message from virtual manifests do not specify [target] to This virtual manifest specifies a [target] section, which is not allowed because the old one confused me.

I encountered it while hacking on Rustc in CLion. I made a change to the Cargo.toml I had copied from StackOverflow and after the next restart code analysis and go-to-definition stopped working. After some fiddling, I tracked that down to my change in Cargo.toml. It took me a while because, like I said, the error message from CLion didn't make sense to me.

19:13	Cargo project update failed:
	Execution failed (exit code 101).
	        /home/julian/.cargo/bin/cargo metadata --verbose --format-version 1 --all-features
	        stdout : error: failed to parse manifest at `/home/julian/Dokumente/Rust/Compiler/rust/Cargo.toml`
	
	Caused by:
	  virtual manifests do not specify [target]
	
	        stderr : 

I hope this change avoids future confusion :)

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[Julian-Wollersberger]

I don't understand that test failure. Locally
cargo +stable test rustc_info passes both before and after this patch, but
cargo +nightly test rustc_info fails both before and after this patch.

It seems to not be related to this patch anyway?
Does someone know what's going on?

[ehuss]

It is an unrelated error. rust-lang/rust#71716 changed some behavior that is causing that test to fail, and Cargo will need to be updated for it.

[Julian-Wollersberger]

Rebased. The previously offending testrustc_info now passes locally.
But this new failure of rebuild_if_build_artifacts_move_forward_in_time also passes locally, both on stable, nightly and self-hosted cargo.
This seems to be unrelated, again.

[ehuss]

Hm, I have never seen that error before, and I can't imagine how it is possible. I tried reproducing it, but I couldn't.

---- freshness::rebuild_if_build_artifacts_move_forward_in_time stdout ----
running `/Users/runner/runners/2.168.2/work/1/s/target/debug/cargo build`
running `/Users/runner/runners/2.168.2/work/1/s/target/debug/cargo build`
thread 'freshness::rebuild_if_build_artifacts_move_forward_in_time' panicked at '
Expected: execs
    but: exited with exit code: 101
--- stdout

--- stderr
   Compiling a v0.0.1 (/Users/runner/runners/2.168.2/work/1/s/target/cit/t796/foo/a)
   Compiling foo v0.0.1 (/Users/runner/runners/2.168.2/work/1/s/target/cit/t796/foo)
error: could not parse/generate dep info at: /Users/runner/runners/2.168.2/work/1/s/target/cit/t796/foo/target/debug/deps/foo-d0e39817788fdb93.d

Caused by:
  malformed dep-info format, no targets
note: this is an unexpected cargo internal error
note: we would appreciate a bug report: ***/issues/
note: cargo 1.45.0

Can probably ignore it for now. If it shows up again, we can investigate more.

[alexcrichton]

Currently all of Cargo's error messages conventionally start with a lowercase letter, mind changing that here? Other than that this seems good to go!

[Julian-Wollersberger]

Done.

[alexcrichton]

@bors: r+

[bors]

📌 Commit d6a1428 has been approved by alexcrichton

[bors]

⌛ Testing commit d6a1428 with merge 2fef2e5...

[bors]

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 2fef2e5 to master...