Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude the target directory from backups using CACHEDIR.TAG #8378

Merged
merged 13 commits into from
Jul 2, 2020
Merged

Exclude the target directory from backups using CACHEDIR.TAG #8378

merged 13 commits into from
Jul 2, 2020

Commits on Jun 18, 2020

  1. Exclude the target directory from backups using CACHEDIR.TAG 

    This patch follows the lead of rust-lang#4386 (which excludes target directories
from Time Machine backups) and is motived by the same reasons listen
in rust-lang#3884. CACHEDIR.TAG is an OS-independent mechanism supported by Borg,
restic, GNU Tar and other backup/archiving solutions.

See https://bford.info/cachedir/ for more information about the
specification. This has been discussed in Rust Internals earlier this
year[1] and it seems like it's an uncontroversial improvement so I went
ahead with the patch.

[1] https://internals.rust-lang.org/t/pre-rfc-put-cachedir-tag-into-target/12262/11
    @jstasiak
    jstasiak committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    cc50118 View commit details
    Browse the repository at this point in the history

  2. Revert one unintentional change

    @jstasiak
    jstasiak committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    4c9efbd View commit details
    Browse the repository at this point in the history

  3. Remove CACHEDIR.TAG as part of cargo clean

    @jstasiak
    jstasiak committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    f9807e0 View commit details
    Browse the repository at this point in the history

  4. Fix a test

    @jstasiak
    jstasiak committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    efac9cc View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Make target directory creation and backup exclusion atomic

    @jstasiak
    jstasiak committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    2793d7b View commit details
    Browse the repository at this point in the history

  2. Make sure the target tempdir is cleaned if rename fails

    @jstasiak
    jstasiak committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ce02401 View commit details
    Browse the repository at this point in the history

  3. Use more appropriate basename for the tempdir

    @jstasiak
    jstasiak committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    7a0001d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Add two tests

    @jstasiak
    jstasiak committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    3eb2ae0 View commit details
    Browse the repository at this point in the history

  2. Try to resolve a build-time conflict with master 

    This commit changed things a bit: 6263d72.
    @jstasiak
    jstasiak committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    50f2290 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Exclude target/doc from backups as well

    @jstasiak
    jstasiak committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    1b5f749 View commit details
    Browse the repository at this point in the history

  2. Exclude whole target/ from backups 

    This is following the discussion on GitHub. The doc tests are no longer
necessary because Layout::new() creates CACHEDIR.TAG directly in target
root, no doc-specific code is necessary anymore.
    @jstasiak
    jstasiak committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    f34b086 View commit details
    Browse the repository at this point in the history

  3. Compress two tests into one

    @jstasiak
    jstasiak committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    092781c View commit details
    Browse the repository at this point in the history

  4. Remove no longer needed cleanup code

    @jstasiak
    jstasiak committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    5f2ba2b View commit details
    Browse the repository at this point in the history