Emit the `test` field in cargo metadata #8478

oli-obk · 2020-07-12T14:53:42Z

This is needed so cargo-metadata can expose it: oli-obk/cargo_metadata#114

rust-highfive · 2020-07-12T14:53:45Z

(rust_highfive has picked a reviewer for you, use r? to override)

ehuss · 2020-07-13T03:14:30Z

Thanks! Looks like there are some tests that need to be updated.

Also, would you mind updating the docs in https://github.com/rust-lang/cargo/blob/master/src/doc/man/cargo-metadata.adoc? There's a Makefile https://github.com/rust-lang/cargo/tree/master/src/doc with some docs for rebuilding the man pages.

oli-obk · 2020-07-13T09:38:14Z

I can't build this locally out of some reason. I'm getting a type error with stable, beta and nightly, but that looks entirely unrelated to my change.

   Compiling cargo v0.47.0 (/home/oliver/Projects/rust/cargo)
error[E0308]: mismatched types
   --> src/cargo/util/paths.rs:489:49
    |
489 |     let tempdir = TempFileBuilder::new().prefix(base).tempdir_in(parent)?;
    |                                                 ^^^^ expected `str`, found struct `std::ffi::OsStr`
    |
    = note: expected reference `&str`
               found reference `&std::ffi::OsStr`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.
error: could not compile `cargo`.

To learn more, run the command again with --verbose.
~/P/r/cargo (master↑1|✔) [101] $ rustc --version
rustc 1.45.0-beta.3 (8196407f0 2020-06-27)

ehuss · 2020-07-13T11:42:02Z

Looks like you may need to update Cargo.lock. The minimum version of tempfile is 3.0.7. We should probably update Cargo.toml to point to the latest 3.1.0.

oli-obk · 2020-07-13T17:13:52Z

Thanks, that did the trick. I updated everything and cargo test passes now

alexcrichton · 2020-07-13T20:11:06Z

I think there might be a nightly test that also needs updating?

src/doc/man/cargo-metadata.adoc

oli-obk · 2020-07-30T07:51:57Z

I think there might be a nightly test that also needs updating?

indeed, ran the test suite with nightly and made it work, too

alexcrichton · 2020-07-30T14:27:20Z

@bors: r+

bors · 2020-07-30T14:27:23Z

📌 Commit 95b22d2 has been approved by alexcrichton

bors · 2020-07-30T14:27:33Z

⌛ Testing commit 95b22d2 with merge d484b65...

bors · 2020-07-30T14:50:28Z

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing d484b65 to master...

Pkgsrc changes: * Remove patches now integrated upstream, many related to SunOS / Illumos. * The LLVM fix for powerpc is also now integrated upstream. * Adapt those patches where the source has moved or parts are integrated. * The randomness patches no longer applies, and I could not find where those files went... * Provide a separate bootstrap for NetBSD/powerpc 9.0, since apparently the C++ ABI is different from 8.0. Yes, this appears to be specific to the NetBSD powerpc ports. Upstream changes: Version 1.47.0 (2020-10-08) ========================== Language -------- - [Closures will now warn when not used.][74869] Compiler -------- - [Stabilized the `-C control-flow-guard` codegen option][73893], which enables [Control Flow Guard][1.47.0-cfg] for Windows platforms, and is ignored on other platforms. - [Upgraded to LLVM 11.][73526] - [Added tier 3\* support for the `thumbv4t-none-eabi` target.][74419] - [Upgrade the FreeBSD toolchain to version 11.4][75204] - [`RUST_BACKTRACE`'s output is now more compact.][75048] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`CStr` now implements `Index<RangeFrom<usize>>`.][74021] - [Traits in `std`/`core` are now implemented for arrays of any length, not just those of length less than 33.][74060] - [`ops::RangeFull` and `ops::Range` now implement Default.][73197] - [`panic::Location` now implements `Copy`, `Clone`, `Eq`, `Hash`, `Ord`, `PartialEq`, and `PartialOrd`.][73583] Stabilized APIs --------------- - [`Ident::new_raw`] - [`Range::is_empty`] - [`RangeInclusive::is_empty`] - [`Result::as_deref`] - [`Result::as_deref_mut`] - [`Vec::leak`] - [`pointer::offset_from`] - [`f32::TAU`] - [`f64::TAU`] The following previously stable APIs have now been made const. - [The `new` method for all `NonZero` integers.][73858] - [The `checked_add`,`checked_sub`,`checked_mul`,`checked_neg`, `checked_shl`, `checked_shr`, `saturating_add`, `saturating_sub`, and `saturating_mul` methods for all integers.][73858] - [The `checked_abs`, `saturating_abs`, `saturating_neg`, and `signum` for all signed integers.][73858] - [The `is_ascii_alphabetic`, `is_ascii_uppercase`, `is_ascii_lowercase`, `is_ascii_alphanumeric`, `is_ascii_digit`, `is_ascii_hexdigit`, `is_ascii_punctuation`, `is_ascii_graphic`, `is_ascii_whitespace`, and `is_ascii_control` methods for `char` and `u8`.][73858] Cargo ----- - [`build-dependencies` are now built with opt-level 0 by default.][cargo/8500] You can override this by setting the following in your `Cargo.toml`. ```toml [profile.release.build-override] opt-level = 3 ``` - [`cargo-help` will now display man pages for commands rather just the `--help` text.][cargo/8456] - [`cargo-metadata` now emits a `test` field indicating if a target has tests enabled.][cargo/8478] - [`workspace.default-members` now respects `workspace.exclude`.][cargo/8485] - [`cargo-publish` will now use an alternative registry by default if it's the only registry specified in `package.publish`.][cargo/8571] Misc ---- - [Added a help button beside Rustdoc's searchbar that explains rustdoc's type based search.][75366] - [Added the Ayu theme to rustdoc.][71237] Compatibility Notes ------------------- - [Bumped the minimum supported Emscripten version to 1.39.20.][75716] - [Fixed a regression parsing `{} && false` in tail expressions.][74650] - [Added changes to how proc-macros are expanded in `macro_rules!` that should help to preserve more span information.][73084] These changes may cause compiliation errors if your macro was unhygenic or didn't correctly handle `Delimiter::None`. - [Moved support for the CloudABI target to tier 3.][75568] - [`linux-gnu` targets now require minimum kernel 2.6.32 and glibc 2.11.][74163] Internal Only -------- - [Improved default settings for bootstrapping in `x.py`.][73964] You can read details about this change in the ["Changes to `x.py` defaults"](https://blog.rust-lang.org/inside-rust/2020/08/30/changes-to-x-py-defaults.html) post on the Inside Rust blog. - [Added the `rustc-docs` component.][75560] This allows you to install and read the documentation for the compiler internal APIs. (Currently only available for `x86_64-unknown-linux-gnu`.) [1.47.0-cfg]: https://docs.microsoft.com/en-us/windows/win32/secbp/control-flow-guard [76980]: rust-lang/rust#76980 [75048]: rust-lang/rust#75048 [74163]: rust-lang/rust#74163 [71237]: rust-lang/rust#71237 [74869]: rust-lang/rust#74869 [73858]: rust-lang/rust#73858 [75716]: rust-lang/rust#75716 [75908]: rust-lang/rust#75908 [75516]: rust-lang/rust#75516 [75560]: rust-lang/rust#75560 [75568]: rust-lang/rust#75568 [75366]: rust-lang/rust#75366 [75204]: rust-lang/rust#75204 [74650]: rust-lang/rust#74650 [74419]: rust-lang/rust#74419 [73964]: rust-lang/rust#73964 [74021]: rust-lang/rust#74021 [74060]: rust-lang/rust#74060 [73893]: rust-lang/rust#73893 [73526]: rust-lang/rust#73526 [73583]: rust-lang/rust#73583 [73084]: rust-lang/rust#73084 [73197]: rust-lang/rust#73197 [72488]: rust-lang/rust#72488 [cargo/8456]: rust-lang/cargo#8456 [cargo/8478]: rust-lang/cargo#8478 [cargo/8485]: rust-lang/cargo#8485 [cargo/8500]: rust-lang/cargo#8500 [cargo/8571]: rust-lang/cargo#8571 [`Ident::new_raw`]: https://doc.rust-lang.org/nightly/proc_macro/struct.Ident.html#method.new_raw [`Range::is_empty`]: https://doc.rust-lang.org/nightly/std/ops/struct.Range.html#method.is_empty [`RangeInclusive::is_empty`]: https://doc.rust-lang.org/nightly/std/ops/struct.RangeInclusive.html#method.is_empty [`Result::as_deref_mut`]: https://doc.rust-lang.org/nightly/std/result/enum.Result.html#method.as_deref_mut [`Result::as_deref`]: https://doc.rust-lang.org/nightly/std/result/enum.Result.html#method.as_deref [`TypeId::of`]: https://doc.rust-lang.org/nightly/std/any/struct.TypeId.html#method.of [`Vec::leak`]: https://doc.rust-lang.org/nightly/std/vec/struct.Vec.html#method.leak [`f32::TAU`]: https://doc.rust-lang.org/nightly/std/f32/consts/constant.TAU.html [`f64::TAU`]: https://doc.rust-lang.org/nightly/std/f64/consts/constant.TAU.html [`pointer::offset_from`]: https://doc.rust-lang.org/nightly/std/primitive.pointer.html#method.offset_from

rust-highfive assigned alexcrichton Jul 12, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2020

ehuss reviewed Jul 13, 2020

View reviewed changes

src/doc/man/cargo-metadata.adoc Outdated Show resolved Hide resolved

ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2020

Emit the test field in cargo metadata

95b22d2

oli-obk force-pushed the master branch from a4a0c93 to 95b22d2 Compare July 30, 2020 07:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jul 30, 2020

bors merged commit d484b65 into rust-lang:master Jul 30, 2020

ehuss mentioned this pull request Sep 2, 2020

Add test field to Target. oli-obk/cargo_metadata#124

Merged

ehuss added this to the 1.47.0 milestone Feb 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emit the `test` field in cargo metadata #8478

Emit the `test` field in cargo metadata #8478

oli-obk commented Jul 12, 2020

rust-highfive commented Jul 12, 2020

ehuss commented Jul 13, 2020

oli-obk commented Jul 13, 2020

ehuss commented Jul 13, 2020

oli-obk commented Jul 13, 2020

alexcrichton commented Jul 13, 2020

oli-obk commented Jul 30, 2020

alexcrichton commented Jul 30, 2020

bors commented Jul 30, 2020

bors commented Jul 30, 2020

bors commented Jul 30, 2020

Emit the test field in cargo metadata #8478

Emit the test field in cargo metadata #8478

Conversation

oli-obk commented Jul 12, 2020

rust-highfive commented Jul 12, 2020

ehuss commented Jul 13, 2020

oli-obk commented Jul 13, 2020

ehuss commented Jul 13, 2020

oli-obk commented Jul 13, 2020

alexcrichton commented Jul 13, 2020

oli-obk commented Jul 30, 2020

alexcrichton commented Jul 30, 2020

bors commented Jul 30, 2020

bors commented Jul 30, 2020

bors commented Jul 30, 2020

Emit the `test` field in cargo metadata #8478

Emit the `test` field in cargo metadata #8478