Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames SourceId::into_url -> SourceId::as_url #8611

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Renames SourceId::into_url -> SourceId::as_url #8611

merged 2 commits into from
Aug 19, 2020

Commits on Aug 11, 2020

  1. Renames SourceId::into_url -> SourceId::as_url 

    While studying the source code, I am surprised to see that `into_url`
does not actually consume the string when a function with such name
usually does. Additionally, there are traits in `cargo::util::IntoUrl`
with the same and does exactly what you expect, consumes T and yields
a `Url`.

I hope this is not too nitpicky.
Thank you!
    @hbina
    hbina committed Aug 11, 2020
    1 Configuration menu
    Copy the full SHA
    79f3512 View commit details
    Browse the repository at this point in the history

  2. Renamed SourceIdIntoUrl -> SourceIdAsUrl

    @hbina
    hbina committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    3dbac42 View commit details
    Browse the repository at this point in the history