Shrink the progress bar, to give more space after it. #8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Because:
- A big progress bar isn't necessary. Making it smaller loses some
precision, but a big bar isn't that precise in the first place. If you
precision you can look at the percentage or ratio figure after the
progress bar anyway.
- A big bar sometimes obscures important info. For the "Building" step
the crate names after the progress bar are important -- they make it
clear how much parallelism is in the build. If you don't see that
you're getting a much worse understanding of the build process.
On an 80-char wide terminal, the change looks like this. Before:
```
Building [========> ] 18/105
```
After:
```
Building [=======================> ] 97/105: goblin, pdb, symbolic-dem...
```
On a 100-char wide terminal, it looks like this. Before:
```
Building [============================> ] 56/105: cpp_demangle(bu...
```
After:
```
Building [============> ] 56/105: byteorder, proc-macro2, pest, gimli, cpp_dema...
```
nnethercote
force-pushed
the
shrink-progress-bar
branch
from
f12574a
to
7e780a9
Compare
|
@bors: r+ Seems reasonable to me, thanks! |
|
📌 Commit 7e780a9 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2020
Update cargo 10 commits in 2af662e22177a839763ac8fb70d245a680b15214..bfca1cd22bf514d5f2b6c1089b0ded0ba7dfaa6e 2020-11-12 19:04:56 +0000 to 2020-11-24 16:33:21 +0000 - Shrink the progress bar, to give more space after it. (rust-lang/cargo#8892) - Add some comments to the toml code (rust-lang/cargo#8887) - Start searching git config at new path (rust-lang/cargo#8886) - Fix documentation for CARGO_PRIMARY_PACKAGE. (rust-lang/cargo#8891) - Bump to 0.51.0, update changelog (rust-lang/cargo#8894) - Publish target's "doc" setting when emitting metadata (rust-lang/cargo#8869) - Relaxes expectation of `cargo test` tests to accept test execution time (rust-lang/cargo#8884) - Finish implementation of `-Zextra-link-arg`. (rust-lang/cargo#8441) - Reproducible crate builds (rust-lang/cargo#8864) - Allow resolver="1" to explicitly use the old resolver behavior. (rust-lang/cargo#8857)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
precision, but a big bar isn't that precise in the first place. If you
precision you can look at the percentage or ratio figure after the
progress bar anyway.
step the crate names after the progress bar are important -- they make
it clear how much parallelism is in the build. If you don't see that
you're getting a much worse understanding of the build process.
On an 80-char wide terminal, the change looks like this. Before:
After:
On a 100-char wide terminal, it looks like this. Before:
After: