Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #8783 , cargo new fails without a author name or email #8912

Merged
merged 11 commits into from
Dec 3, 2020
Merged

Fixes #8783 , cargo new fails without a author name or email #8912

merged 11 commits into from
Dec 3, 2020

Commits on Nov 29, 2020

  1. Fixes rust-lang#8783 

    If user can not be obtained from git or env variables $USER, new command defaults to empty author in generated Cargo.toml
    @aniljava
    aniljava committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    15f2cdb View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Fix: unavailable author for cargo new 

    - if author name and email not found from config or env variables, defaults to an empty author list authors = []
- simplified selection of name + email from available choices in (fn mk)
    @aniljava
    aniljava committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    5c09ad1 View commit details
    Browse the repository at this point in the history

  2. Test cargo new with missing authors 

    - test case for missing name and email (author_without_user_or_email)
- test case for handling email only (finds_author_email_only)
    @aniljava
    aniljava committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    917fc99 View commit details
    Browse the repository at this point in the history

  3. changed return type as discover_author no longer bails 

    Return type changed to plain tuples instead of CargoResult as the function does not bail with error if the author name is missing.
    @aniljava
    aniljava committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    9b3e6f7 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' 

    Remote
    @aniljava
    aniljava committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    38694d4 View commit details
    Browse the repository at this point in the history

  5. Replaced the match arm with better coding convention.

    @aniljava
    aniljava committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    782dacd View commit details
    Browse the repository at this point in the history

  6. Removed debug println from earlier commit.

    @aniljava
    aniljava committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    fad1681 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master'

    @aniljava
    aniljava committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    65f2a87 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Explicitly removed USER env variables.

    @aniljava
    aniljava committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    4eeadfb View commit details
    Browse the repository at this point in the history

  2. rustfmt

    @aniljava
    aniljava committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    4787dd3 View commit details
    Browse the repository at this point in the history

  3. Removed debug println!

    @aniljava
    aniljava committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    a006347 View commit details
    Browse the repository at this point in the history