Document could not find the github team error on cargo owner --add
#9000
Conversation
|
r? @Eh2406 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
src/doc/src/reference/publishing.md
Outdated
| @@ -240,8 +240,23 @@ the “Grant Access” button next to its name: | |||
|
|
|||
|  | |||
|
|
|||
| #### could not find the github team | |||
There was a problem hiding this comment.
This looks a little strange starting with a lowercase letter.
There was a problem hiding this comment.
So, "`could not find the github team` error" is fine?
There was a problem hiding this comment.
Maybe "Troubleshooting GitHub team access errors"?
src/doc/src/reference/publishing.md
Outdated
| ``` | ||
| In that case, you should go to [the GitHub Application settings page] and | ||
| check if crates.io is listed in the `Authorized OAuth Apps` tab. | ||
| If it isn't, you should go to <https://crates.io/login> and authorize it. |
There was a problem hiding this comment.
https://crates.io/login doesn't seem to be a valid URL.
There was a problem hiding this comment.
Oh, the error message on crates.io is outdated, will fix it.
There was a problem hiding this comment.
The message was updated by rust-lang/crates.io#3146.
src/doc/src/reference/publishing.md
Outdated
| @@ -240,8 +240,23 @@ the “Grant Access” button next to its name: | |||
|
|
|||
|  | |||
|
|
|||
| #### could not find the github team | |||
|
|
|||
| Or, when trying to add a GitHub team as crate owner, you may see an error like: | |||
There was a problem hiding this comment.
I'm not sure what the leading "or" here is for.
| Or, when trying to add a GitHub team as crate owner, you may see an error like: | |
| When trying to add a GitHub team as crate owner, you may see an error like: |
src/doc/src/reference/publishing.md
Outdated
| In that case, you should go to [the GitHub Application settings page] and | ||
| check if crates.io is listed in the `Authorized OAuth Apps` tab. | ||
| If it isn't, you should go to <https://crates.io/login> and authorize it. | ||
| Then go to the crates.io app page, make sure you or your organization |
There was a problem hiding this comment.
I'm uncertain what the "app page" is.
This also might flow a little better like this:
| Then go to the crates.io app page, make sure you or your organization | |
| Then go to the crates.io app page and make sure you or your organization |
There was a problem hiding this comment.
I'm uncertain what the "app page" is.
This one: https://github.com/settings/connections/applications/9fe8110dfe185fe90b5c
I'm not sure what's the best wording for it, any idea?
There was a problem hiding this comment.
Ah, I would try to be explicit about exactly what to do. Maybe something like this:
Then go back to the Application Settings page on GitHub, click on the
crates.io application in the list, and make sure you or your organization is
listed in the "Organization access" list with a green check mark. If there's
a button labeledGrantorRequest, you should grant the access or
request the org owner to do so.
Remove outdated information about GitHub permission error https://crates.io/login is no longer valid (found in rust-lang/cargo#9000 (comment)) and it's just enough to recommend re-authentication now, I think.
|
r? @ehuss |
|
Thanks! Updated the wording following the reviews. |
|
Thanks! @bors r+ |
|
📌 Commit 4be6c18 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 10 commits in 329895f5b52a358e5d9ecb26215708b5cb31d906..a73e5b7d567c3036b296fc6b33ed52c5edcd882e 2021-01-06 00:01:52 +0000 to 2021-01-12 23:45:39 +0000 - Sort available binaries when multiple (rust-lang/cargo#9066) - Fix misspelling of environment variable (rust-lang/cargo#9067) - Remove statement that opt-level 0 turns on debug (rust-lang/cargo#9070) - Fix `links` vars showing up for testing packages (rust-lang/cargo#9065) - Fix unit_for computation on proc-macros in shared workspace. (rust-lang/cargo#9059) - Document `could not find the github team` error on `cargo owner --add` (rust-lang/cargo#9000) - Unstable section of cargo/config.toml takes bools (rust-lang/cargo#9057) - [doc] add note about empty environment variables for missing manifest keys (rust-lang/cargo#9053) - another round of clippy lint fixes (rust-lang/cargo#9051) - Updated display message of cargo metadata --help (rust-lang/cargo#9050)
When running
cargo owner --add, thecould not find the github teamerror often occurs due to lack of the permissions.Example cases: #5297 (comment), rust-lang/crates.io#2928
I think it's worth documenting that error and the possible solution.