Do not exit prematurely if anything failed installing. #9185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! Do you think you can add a test for this? It should probably go in |
|
I can give it a try for sure.
Thanks,
H
…On Thu, 18 Feb 2021, 15:38 Eric Huss, ***@***.***> wrote:
Thanks! Do you think you can add a test for this? It should probably go in
testsuite/install.rs
<https://github.com/rust-lang/cargo/blob/master/tests/testsuite/install.rs>,
and there's a bunch of examples in there. There is documentation for
running and writing tests at
https://doc.crates.io/contrib/tests/index.html.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9185 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKFPWDXNAW25ASVPFZPM2TS7URAHANCNFSM4XZ36CNQ>
.
|
|
added test; let's see if this is of use. |
|
Thanks! @bors r+ |
|
📌 Commit dab646e has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Feb 22, 2021
Do not exit prematurely if anything failed installing. rust-lang#9180
bors
added a commit
that referenced
this pull request
Feb 22, 2021
[beta] backports for 1.51 Beta backports for the following: * Fix panic with doc collision orphan. (#9142) * This is an important regression that is fairly easy to hit. * Do not exit prematurely if anything failed installing. (#9185) * This is not a regression, but I think an important fix. * Add schema field to the index (#9161) * This is only the first commit from the PR which checks for the `v` field in the index, and skips entries that are not understood. The reason to backport is to get this in as early as possible so that if we do decide to start using it in the future, it works as early as possible. This otherwise doesn't do anything, so I think it should be safe. * Fix warnings of the new non_fmt_panic lint (#9148) * Fixes CI for a new warning in nightly.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2021
[beta] Update cargo Backport of rust-lang/cargo#9196: * Fix panic with doc collision orphan. (rust-lang/cargo#9142) * Do not exit prematurely if anything failed installing. (rust-lang/cargo#9185) * Add schema field to the index (rust-lang/cargo#9161) * Fix warnings of the new non_fmt_panic lint (rust-lang/cargo#9148)
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 27, 2021
Update cargo 11 commits in bf5a5d5e5d3ae842a63bfce6d070dfd438cf6070..572e201536dc2e4920346e28037b63c0f4d88b3c 2021-02-18 15:49:14 +0000 to 2021-02-24 16:51:20 +0000 - Pass the error message format to rustdoc (rust-lang/cargo#9128) - Fix test target_in_environment_contains_lower_case (rust-lang/cargo#9203) - Fix hang on broken stderr. (rust-lang/cargo#9201) - Make it more clear which module is being tested when running cargo test (rust-lang/cargo#9195) - Updates to edition handling. (rust-lang/cargo#9184) - Add --cfg and --rustc-cfg flags to output compiler configuration (rust-lang/cargo#9002) - Run rustdoc doctests relative to the workspace (rust-lang/cargo#9105) - Add support for [env] section in .cargo/config.toml (rust-lang/cargo#9175) - Add schema field and `features2` to the index. (rust-lang/cargo#9161) - Document the default location where cargo install emitting build artifacts (rust-lang/cargo#9189) - Do not exit prematurely if anything failed installing. (rust-lang/cargo#9185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9180