Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning for no lib dependencies #9771

Merged
merged 5 commits into from
Aug 23, 2021
Merged

Warning for no lib dependencies #9771

merged 5 commits into from
Aug 23, 2021

Conversation

Rustin170506
Copy link
Member

close #6702

@Rustin170506
Warning for no lib dependencies
cc891a0 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2021
@Rustin170506
Use batch warnings and only warn about used dependency packages
27c1030 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 marked this pull request as ready for review August 7, 2021 06:47
@Rustin170506 Rustin170506 mentioned this pull request Aug 7, 2021
Closed
nipunn1313
nipunn1313 reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@nipunn1313 nipunn1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I'm not a maintainer, but I took a look and reviewed. Feel free to take-or-leave any of the ideas.

tests/testsuite/run.rs Outdated Show resolved Hide resolved
src/cargo/core/package.rs Outdated Show resolved Hide resolved
src/cargo/core/package.rs Outdated Show resolved Hide resolved
src/cargo/core/package.rs Outdated Show resolved Hide resolved
@Rustin170506
Just return a vec
f127831 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Separate warning and with root_id
61780a9 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
ehuss
ehuss reviewed Aug 15, 2021
View reviewed changes
src/cargo/ops/resolve.rs Outdated Show resolved Hide resolved
src/cargo/ops/resolve.rs Outdated Show resolved Hide resolved
@ehuss ehuss assigned ehuss and unassigned Eh2406 Aug 15, 2021
nipunn1313
nipunn1313 reviewed Aug 15, 2021
View reviewed changes
Copy link
Contributor

@nipunn1313 nipunn1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice diff!

src/cargo/core/package.rs Show resolved Hide resolved
src/cargo/core/package.rs Outdated Show resolved Hide resolved
@Rustin170506
Refine warnings and better code
0b543ba 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Copy link
Member Author

@ehuss Could we merge it now? All comments addressed. Thanks!

@ehuss
Copy link
Contributor

ehuss commented Aug 22, 2021

Thanks! I'm still not 100% certain resolve_ws_with_opts is really the best place for the check, but I can't think of a better location.

@bors r+

@bors
Copy link
Contributor

bors commented Aug 22, 2021

📌 Commit 0b543ba has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2021
@bors
Copy link
Contributor

bors commented Aug 22, 2021

⌛ Testing commit 0b543ba with merge a0ebc1eb30b2622edc82b251c78e81ade5695eb4...

@ehuss
Copy link
Contributor

ehuss commented Aug 22, 2021

Oh, oops, CI will fail until #9824 is merged.

@bors
Copy link
Contributor

bors commented Aug 22, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2021
@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2021
@bors
Copy link
Contributor

bors commented Aug 23, 2021

⌛ Testing commit 0b543ba with merge 491deb6...

@bors
Copy link
Contributor

bors commented Aug 23, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 491deb6 to master...

@bors bors merged commit 491deb6 into rust-lang:master Aug 23, 2021
@ehuss ehuss mentioned this pull request Aug 24, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 26, 2021
@Dylan-DPC
Rollup merge of rust-lang#88278 - ehuss:update-cargo, r=ehuss
2794409 
Update cargo

16 commits in e96bdb0c3d0a418e7fcd7fbd69be08abf830b4bc..9b81660b79832f92512edd4c29059a9ff88fcb6c
2021-08-17 22:58:47 +0000 to 2021-08-23 20:04:47 +0000
- Fix panic with build-std of a proc-macro. (rust-lang/cargo#9834)
- Fix typos “a”→“an” (rust-lang/cargo#9821)
- Fix typo in git-authentication.md (rust-lang/cargo#9832)
- Add some debug logging for `cargo fix` (rust-lang/cargo#9831)
- Add documentation about third-party registries. (rust-lang/cargo#9830)
- unset the FIX_ENV when executing the real rustc (rust-lang/cargo#9818)
- Allow crate download by checksum (rust-lang/cargo#9801)
- Emit warning for migrating to unstable edition in stable channel (rust-lang/cargo#9792)
- Warning for no lib dependencies (rust-lang/cargo#9771)
- Temporarily disable extern-html-root-url test. (rust-lang/cargo#9824)
- Move `tmp` test directory. (rust-lang/cargo#9814)
- Fix test incorrectly validating CARGO_PKG_LICENSE_FILE. (rust-lang/cargo#9813)
- Implement `[future-incompat-report]` config section (rust-lang/cargo#9774)
- Bump curl. (rust-lang/cargo#9809)
- Determine packages to install prior to installing (rust-lang/cargo#9793)
- Show feature resolver differences for dev-dependencies. (rust-lang/cargo#9803)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 26, 2021
@Dylan-DPC
Rollup merge of rust-lang#88278 - ehuss:update-cargo, r=ehuss
76db2ab 
Update cargo

16 commits in e96bdb0c3d0a418e7fcd7fbd69be08abf830b4bc..9b81660b79832f92512edd4c29059a9ff88fcb6c
2021-08-17 22:58:47 +0000 to 2021-08-23 20:04:47 +0000
- Fix panic with build-std of a proc-macro. (rust-lang/cargo#9834)
- Fix typos “a”→“an” (rust-lang/cargo#9821)
- Fix typo in git-authentication.md (rust-lang/cargo#9832)
- Add some debug logging for `cargo fix` (rust-lang/cargo#9831)
- Add documentation about third-party registries. (rust-lang/cargo#9830)
- unset the FIX_ENV when executing the real rustc (rust-lang/cargo#9818)
- Allow crate download by checksum (rust-lang/cargo#9801)
- Emit warning for migrating to unstable edition in stable channel (rust-lang/cargo#9792)
- Warning for no lib dependencies (rust-lang/cargo#9771)
- Temporarily disable extern-html-root-url test. (rust-lang/cargo#9824)
- Move `tmp` test directory. (rust-lang/cargo#9814)
- Fix test incorrectly validating CARGO_PKG_LICENSE_FILE. (rust-lang/cargo#9813)
- Implement `[future-incompat-report]` config section (rust-lang/cargo#9774)
- Bump curl. (rust-lang/cargo#9809)
- Determine packages to install prior to installing (rust-lang/cargo#9793)
- Show feature resolver differences for dev-dependencies. (rust-lang/cargo#9803)
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2021
@bors
Auto merge of rust-lang#88278 - ehuss:update-cargo, r=ehuss
720a1b2 
Update cargo

19 commits in e96bdb0c3d0a418e7fcd7fbd69be08abf830b4bc..f559c109cc79fe413a8535fb620a5a58b3823d94
2021-08-17 22:58:47 +0000 to 2021-08-26 22:54:55 +0000
- Fix test not to rely on `cargo` in PATH. (rust-lang/cargo#9843)
- Improve resolver message to include dependency requirements (rust-lang/cargo#9827)
- Add hint for cargo metadata in environment section (rust-lang/cargo#9836)
- Fix panic with build-std of a proc-macro. (rust-lang/cargo#9834)
- Fix typos “a”→“an” (rust-lang/cargo#9821)
- Fix typo in git-authentication.md (rust-lang/cargo#9832)
- Add some debug logging for `cargo fix` (rust-lang/cargo#9831)
- Add documentation about third-party registries. (rust-lang/cargo#9830)
- unset the FIX_ENV when executing the real rustc (rust-lang/cargo#9818)
- Allow crate download by checksum (rust-lang/cargo#9801)
- Emit warning for migrating to unstable edition in stable channel (rust-lang/cargo#9792)
- Warning for no lib dependencies (rust-lang/cargo#9771)
- Temporarily disable extern-html-root-url test. (rust-lang/cargo#9824)
- Move `tmp` test directory. (rust-lang/cargo#9814)
- Fix test incorrectly validating CARGO_PKG_LICENSE_FILE. (rust-lang/cargo#9813)
- Implement `[future-incompat-report]` config section (rust-lang/cargo#9774)
- Bump curl. (rust-lang/cargo#9809)
- Determine packages to install prior to installing (rust-lang/cargo#9793)
- Show feature resolver differences for dev-dependencies. (rust-lang/cargo#9803)
@ehuss ehuss added this to the 1.56.0 milestone Feb 6, 2022
@weihanglo weihanglo mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nipunn1313 nipunn1313 nipunn1313 left review comments

@ehuss ehuss Awaiting requested review from ehuss

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

Warn if dependency doesn't have library target kind
7 participants
@Rustin170506 @rust-highfive @ehuss @bors @alexcrichton @nipunn1313 @Eh2406