Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust_metadata to SerializedPackage #9967

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Oct 8, 2021

After the rust_version field was stabilized in #9732 this adds the
rust_version as output to the cargo metadata command, so tools like
Clippy can read and use it as well.

We will probably need this for rust-lang/rust-clippy#7765

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2021
After the rust_version field was stabilized in rust-lang#9732 this adds the
rust_version as output to the `cargo metadata` command, so tools like
Clippy can read and use it as well.
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 12, 2021

📌 Commit 390af27 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2021
@bors
Copy link
Contributor

bors commented Oct 12, 2021

⌛ Testing commit 390af27 with merge 2e6a4e1...

@bors
Copy link
Contributor

bors commented Oct 12, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 2e6a4e1 to master...

@bors bors merged commit 2e6a4e1 into rust-lang:master Oct 12, 2021
@flip1995 flip1995 deleted the rust_version_meta branch October 12, 2021 17:01
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2021
Update cargo

6 commits in c7957a74bdcf3b11e7154c1a9401735f23ebd484..7fbbf4e8f23e3c24b8afff541dcb17e53eb5ff88
2021-10-11 20:17:07 +0000 to 2021-10-19 02:16:48 +0000
- Make future-incompat-report output more user-friendly (rust-lang/cargo#9953)
- Fix fetching git repos after a force push. (rust-lang/cargo#9979)
- Add rustc-link-args to doctest build (rust-lang/cargo#9916)
- Add the start of a basic benchmarking suite. (rust-lang/cargo#9955)
- Use forms for issue templates. (rust-lang/cargo#9970)
- Add rust_metadata to SerializedPackage (rust-lang/cargo#9967)
ehuss added a commit to ehuss/cargo_metadata that referenced this pull request Oct 22, 2021
ehuss added a commit to ehuss/cargo_metadata that referenced this pull request Oct 24, 2021
flip1995 added a commit to flip1995/cargo_metadata that referenced this pull request Oct 27, 2021
Follow up to rust-lang/cargo#9967

This didn't make it into 1.56 with the rust-version stabilization, but
only into 1.58.
@ehuss ehuss added this to the 1.58.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants