Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc 1.0.87 produces tons of warnings on cargo check #970

Closed
ahlinc opened this issue Feb 24, 2024 · 2 comments · Fixed by #972
Closed

cc 1.0.87 produces tons of warnings on cargo check #970

ahlinc opened this issue Feb 24, 2024 · 2 comments · Fixed by #972

Comments

@ahlinc
Copy link
Contributor

ahlinc commented Feb 24, 2024

After update to the latest cc 1.0.87 I see tons of warnings for every dependency crate that uses cc in its build.rs.
Warnings looks like:

warning: some-dependency-crate@0.0.1: running: "cc" "--version"
warning: some-dependency-crate@0.0.1: exit status: 0
warning: some-dependency-crate@0.0.1: running: "cc" "--version"
warning: some-dependency-crate@0.0.1: exit status: 0
warning: some-dependency-crate@0.0.1: running: "cc" "--version"
warning: some-dependency-crate@0.0.1: exit status: 0
warning: some-dependency-crate@0.0.1: running: "cc" "--version"
warning: some-dependency-crate@0.0.1: exit status: 0
warning: some-dependency-crate@0.0.1: running: "ar" "s" "/home/user/some-code/target/debug/build/some-dependency-crate-b229f6f8a8f92087/out/libfoo.a"
warning: some-dependency-crate@0.0.1: exit status: 0

It seems like that some debug logging was overlooked and now the cc crate reports all sub command exit statuses as cargo warnings.

@NobodyXu
Copy link
Collaborator

It's #960 where I suggest to turn them into warnings, I think we need to add a new debugging printing that is enabled by default (but without cargo:warning= prefix so it's not shown by default), that can be disabled.

@NobodyXu
Copy link
Collaborator

cc @amaanq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants