-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move debug logging behind a debug flag that is disabled by default #972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I forgot to post my comment 😂
Would cut a new release soon once this PR is merged. |
No worries, github ux isn't exactly the most clear with that ;) |
66b9fa1
to
cb22cde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you try setting the env locally and see if it prints the debug output as expected please?
Okay so I tried it in 2 spots, I think it's good 1 is building 2 is when tree-sitter builds and runs cc at runtime to compile parsers, setting the env var correctly displays the output that was previously force printed always. So I think it's good now, this is much better than before |
Thank you! |
Thanks a ton for guiding me with this! Really helps :) |
Closes #970
Closes #971