fix(env_tool): return None if env is empty #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathaysia
force-pushed
the
bugfix/empty_ar
branch
from
597b58f
to
28cee90
Compare
NobodyXu
requested changes
Apr 1, 2024
cathaysia
force-pushed
the
bugfix/empty_ar
branch
2 times, most recently
from
90081c6
to
c5708f8
Compare
|
Is anything blocking this? |
NobodyXu
requested changes
Apr 2, 2024
I was working on something else, but generally I will response within a few hours. Your PR generally looks good to me, just have a little bit to improve on, before merging it in. |
Signed-off-by: DragonBillow <DragonBillow@outlook.com>
cathaysia
force-pushed
the
bugfix/empty_ar
branch
from
c5708f8
to
1e5e295
Compare
NobodyXu
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime env maybe a empty value, we should return None in this case: