Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -mfloat-abi=hard as a default argument when using any arm/thumb-none-eabihf target #1194

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add -mfloat-abi=hard as a default argument when using any arm/thumb-none-eabihf target #1194

merged 1 commit into from
Aug 26, 2024

Conversation

chrisnc
Copy link
Contributor

@chrisnc chrisnc commented Aug 26, 2024

Fixes #1193.

NobodyXu
NobodyXu reviewed Aug 26, 2024
View reviewed changes
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@chrisnc chrisnc marked this pull request as ready for review August 26, 2024 13:49
NobodyXu
NobodyXu approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NobodyXu NobodyXu merged commit ad5d37b into rust-lang:main Aug 26, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Merged
@chrisnc chrisnc deleted the armv7a-none-eabihf-fix branch August 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-mfloat-abi=hard should be a default flag for the armv7a-none-eabihf target
2 participants
@chrisnc @NobodyXu