Reduce the need for the host target triple #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems unnecessary to me that the user needs to specify the host target triple when using
ccoutside a build script,ccought to be able to figure it out from context. This is harder than it seems though, for examplearmv6-unknown-freebsdcross compiling toarmv7-unknown-freebsd(however unlikely) would be impossible to determine using justtarget_*cfgs.For now, though, I've removed the internal
get_hosthelper, and replaced it withget_is_cross_compile, and then usedcfg!(...)in the places where we were reading from the host variable before.Tangentially related to #1219.