Add support for C/C++ compiler for Neutrino QNX: `qcc` #1319

flba-eb · 2024-12-12T13:18:47Z

This adds support for using the C/C++ compiler qcc from Neutrino QNX, with the target parameters required.

So far, it was required to set various environment variables.

CC: @jonathanpallant @japaric @gh-tr @AkhilTThomas

NobodyXu

Thanks, is it possible to setup CI and a new test to actually use qcc for testing

flba-eb · 2024-12-12T13:57:03Z

Unfortunately this is not possible because qcc requires a paid license.

jonathanpallant · 2024-12-12T14:02:06Z

Is this going to let us drop all the CFLAGS_<target> environment variables from the QNX Neutrino libstd builds?

Ah, the link says yes.

flba-eb · 2024-12-12T14:02:48Z

Is this going to let us drop all the CFLAGS_<target> environment variables from the QNX Neutrino libstd builds?

Yes, see also rust-lang/rust#134211 😄

src/lib.rs

NobodyXu · 2024-12-12T14:15:11Z

Not very familiar with Neutrino QNX, cc @madsmtm can you have a look at this PR please?

src/lib.rs

madsmtm · 2024-12-12T15:37:08Z

src/lib.rs

@@ -2803,6 +2818,8 @@ impl Build {
                    format!("arm-kmc-eabi-{}", gnu)
                } else if target.arch == "aarch64" && target.vendor == "kmc" {
                    format!("aarch64-kmc-elf-{}", gnu)
+                } else if target.os == "nto" {
+                    "qcc".into()


It sounds like this target only supports compiling with qcc, is that true?

If so, @NobodyXu is this the right place to set this up? This would only select the default compiler, right? What if the user passes cc::Build::new().compiler("clang")? Is the expected behaviour to still try to use Clang, even though we know that'll fail?

It sounds like this target only supports compiling with qcc, is that true?

I think/guess you have to use qcc if you want to include system header files due to license reasons. In other words, usually only qcc is used.
If someone wants to use a very non-default compiler, they can set it via environment variables.

My concern is that if we add the -V flag, then you won't be able to compile with other compilers that don't support that flag

I get your point. Thinking about my previous statement: It's not just header files, you also cannot link to create executables or shared objects without license violations. I don't think we need to support non-qcc compilers.

Cool, thanks for the clarification.

Gonna keep this open pending answer wrt. default vs. required compiler.

I don't think anyone is compiling for QNX Neutrino and not using qcc. If you pay this much for your RTOS, you colour between the lines, not outside.

I meant, I wanted @NobodyXu to confirm that this was the best place to set it up ;)

madsmtm · 2024-12-12T15:37:45Z

(Also not familiar with Neutrino QNX, I'm fine with deferring to the target maintainers here)

madsmtm

Thanks!

Final few questions from me:

Do we need to do something else to support the io-pkt/io-sock divide? Do we need to pass a special flag or something?
Is there a compiler flag for choosing between 7.0, 7.1 and 8.0? E.g. do we actually need to pass e.g. -V7.0,gcc_ntoaarch64le_cxx, or am I misunderstanding that?

flba-eb · 2024-12-12T16:19:20Z

Thanks!

Final few questions from me:

Do we need to do something else to support the io-pkt/io-sock divide? Do we need to pass a special flag or something?

Only linking requires an additional library search path which is added by rustc when rustc links. As far as I understand cc, it never calls a linker itself. If cc can be used to link shared objects / executables, then it would make sense to investigate.

Is there a compiler flag for choosing between 7.0, 7.1 and 8.0? E.g. do we actually need to pass e.g. -V7.0,gcc_ntoaarch64le_cxx, or am I misunderstanding that?

No, I'm only adding -Vgcc_ntoaarch64le_cxx. The version number is optional. Also, this version relates to the used compiler version (e.g. "gcc 8.3"), not the QNX version.

jonathanpallant · 2024-12-12T16:41:02Z

The correct compiler is added to your PATH by running a shell script / batch file supplied with the QNX Software Development Platform, so you can't have both QNX SDP 8.0 and QNX SDP 7.1 (for example) versions of qcc in your PATH at the same time.

jonathanpallant · 2024-12-12T16:41:46Z

(and the OS is called QNX Neutrino, not Neutrino QNX, fwiw)

madsmtm · 2024-12-12T16:47:49Z

Only linking requires an additional library search path which is added by rustc when rustc links. As far as I understand cc, it never calls a linker itself. If cc can be used to link shared objects / executables, then it would make sense to investigate.

I think cc does somewhat support this with Build::shared_flag, though I'm not familiar with how well we support it (and I definitely won't block this PR on that).

The correct compiler is added to your PATH by running a shell script / batch file supplied with the QNX Software Development Platform, so you can't have both QNX SDP 8.0 and QNX SDP 7.1 (for example) versions of qcc in your PATH at the same time.

I'm just worried that users might have e.g. QNX SDP 7.1 configured while building the aarch64-unknown-nto-qnx700 target, is there a check against such incompatibilities anywhere?

flba-eb · 2024-12-12T16:57:08Z

The correct compiler is added to your PATH by running a shell script / batch file supplied with the QNX Software Development Platform, so you can't have both QNX SDP 8.0 and QNX SDP 7.1 (for example) versions of qcc in your PATH at the same time.

I'm just worried that users might have e.g. QNX SDP 7.1 configured while building the aarch64-unknown-nto-qnx700 target, is there a check against such incompatibilities anywhere?

The toolchain does not reveal the QNX version, unfortunately. You would need to start parsing header files, like I've tried with rust-lang/libc#4192 ... but as also written there:
Even if you are having QNX 7.1 on the target and a QNX 7.1 toolchain, it does not mean they are compatible. Sometimes, values and/or signatures can change in header files between "sub versions" (e.g. which provide special, hardware/project dependent improvements) of e.g. 7.1.

madsmtm · 2024-12-12T17:01:53Z

Fair, it's unfortunate that that's the state of things, but I guess we don't need to do anything in cc to avoid it then.

src/lib.rs

…er-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: `@jonathanpallant` `@japaric` `@gh-tr` `@AkhilTThomas`

…er-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: ``@jonathanpallant`` ``@japaric`` ``@gh-tr`` ``@AkhilTThomas``

…er-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: ```@jonathanpallant``` ```@japaric``` ```@gh-tr``` ```@AkhilTThomas```

NobodyXu

Thank you!

…er-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: ````@jonathanpallant```` ````@japaric```` ````@gh-tr```` ````@AkhilTThomas````

…er-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: `````@jonathanpallant````` `````@japaric````` `````@gh-tr````` `````@AkhilTThomas`````

…er-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: ``````@jonathanpallant`````` ``````@japaric`````` ``````@gh-tr`````` ``````@AkhilTThomas``````

…er-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: ```````@jonathanpallant``````` ```````@japaric``````` ```````@gh-tr``````` ```````@AkhilTThomas```````

…er-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: ````````@jonathanpallant```````` ````````@japaric```````` ````````@gh-tr```````` ````````@AkhilTThomas````````

Rollup merge of rust-lang#134211 - flba-eb:add_qnx_archiver, r=compiler-errors On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: ````````@jonathanpallant```````` ````````@japaric```````` ````````@gh-tr```````` ````````@AkhilTThomas````````

On Neutrino QNX, reduce the need to set archiver via environment variables This adds support for automatically selecting the correct `ar` tool when compiling for Neutrino QNX. Once rust-lang/cc-rs#1319 is merged and a new cc version is integrated, all environment variables of the [Neutrino documentation](https://github.com/rust-lang/rust/blob/stable/src/doc/rustc/src/platform-support/nto-qnx.md) can be removed. CC: ````````@jonathanpallant```````` ````````@japaric```````` ````````@gh-tr```````` ````````@AkhilTThomas````````

NobodyXu requested changes Dec 12, 2024

View reviewed changes

flba-eb mentioned this pull request Dec 12, 2024

On Neutrino QNX, reduce the need to set archiver via environment variables rust-lang/rust#134211

Merged

NobodyXu requested changes Dec 12, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

flba-eb force-pushed the set_qcc branch from 78fd0a0 to 66a1b1f Compare December 12, 2024 14:17

madsmtm reviewed Dec 12, 2024

View reviewed changes

flba-eb force-pushed the set_qcc branch from 66a1b1f to 49af730 Compare December 12, 2024 15:50

madsmtm approved these changes Dec 12, 2024

View reviewed changes

madsmtm reviewed Dec 12, 2024

View reviewed changes

src/lib.rs Show resolved Hide resolved

Add support for C/C++ compiler for Neutrino QNX: qcc

bd5758d

flba-eb force-pushed the set_qcc branch from 49af730 to bd5758d Compare December 12, 2024 18:06

NobodyXu approved these changes Dec 13, 2024

View reviewed changes

NobodyXu merged commit 82c8c7b into rust-lang:main Dec 13, 2024
27 checks passed

github-actions bot mentioned this pull request Dec 13, 2024

chore: release v1.2.4 #1320

Merged

flba-eb deleted the set_qcc branch December 13, 2024 10:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for C/C++ compiler for Neutrino QNX: `qcc` #1319

Add support for C/C++ compiler for Neutrino QNX: `qcc` #1319

flba-eb commented Dec 12, 2024

NobodyXu left a comment

flba-eb commented Dec 12, 2024

jonathanpallant commented Dec 12, 2024 •

edited

Loading

flba-eb commented Dec 12, 2024

NobodyXu commented Dec 12, 2024

madsmtm Dec 12, 2024

flba-eb Dec 12, 2024

madsmtm Dec 12, 2024

flba-eb Dec 12, 2024

madsmtm Dec 12, 2024

jonathanpallant Dec 12, 2024

madsmtm Dec 12, 2024

madsmtm commented Dec 12, 2024 •

edited

Loading

madsmtm left a comment

flba-eb commented Dec 12, 2024

jonathanpallant commented Dec 12, 2024

jonathanpallant commented Dec 12, 2024

madsmtm commented Dec 12, 2024 •

edited

Loading

flba-eb commented Dec 12, 2024 •

edited

Loading

madsmtm commented Dec 12, 2024

NobodyXu left a comment

Add support for C/C++ compiler for Neutrino QNX: qcc #1319

Add support for C/C++ compiler for Neutrino QNX: qcc #1319

Conversation

flba-eb commented Dec 12, 2024

NobodyXu left a comment

Choose a reason for hiding this comment

flba-eb commented Dec 12, 2024

jonathanpallant commented Dec 12, 2024 • edited Loading

flba-eb commented Dec 12, 2024

NobodyXu commented Dec 12, 2024

madsmtm Dec 12, 2024

Choose a reason for hiding this comment

flba-eb Dec 12, 2024

Choose a reason for hiding this comment

madsmtm Dec 12, 2024

Choose a reason for hiding this comment

flba-eb Dec 12, 2024

Choose a reason for hiding this comment

madsmtm Dec 12, 2024

Choose a reason for hiding this comment

jonathanpallant Dec 12, 2024

Choose a reason for hiding this comment

madsmtm Dec 12, 2024

Choose a reason for hiding this comment

madsmtm commented Dec 12, 2024 • edited Loading

madsmtm left a comment

Choose a reason for hiding this comment

flba-eb commented Dec 12, 2024

jonathanpallant commented Dec 12, 2024

jonathanpallant commented Dec 12, 2024

madsmtm commented Dec 12, 2024 • edited Loading

flba-eb commented Dec 12, 2024 • edited Loading

madsmtm commented Dec 12, 2024

NobodyXu left a comment

Choose a reason for hiding this comment

Add support for C/C++ compiler for Neutrino QNX: `qcc` #1319

Add support for C/C++ compiler for Neutrino QNX: `qcc` #1319

jonathanpallant commented Dec 12, 2024 •

edited

Loading

madsmtm commented Dec 12, 2024 •

edited

Loading

madsmtm commented Dec 12, 2024 •

edited

Loading

flba-eb commented Dec 12, 2024 •

edited

Loading