Simplify the error output on failed Command
invocation
#1397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing around the
program
we wanted to execute incommand_helpers.rs
is unnecessary, we can retrieve it fromCommand::get_program
instead when required, and that path is usually more descriptive anyhow.Motivation
I'm currently debugging this. The error that
cc-rs
gives is:This was confusing, as "aarch64-unknown-fuchsia-clang" is really the compiler and not "args". Besides, I didn't actually need to know that the tool we "wanted" to invoke; that is evident from the pretty-printed command line arguments.
With this PR, the above error would have been:
Which is shorter, and makes it clearer where the command starts and ends (after the colon and at the end of the line).