fix find_tool and find_vs_version might returns incompatible values #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speedy37
force-pushed
the
fix-msvc-version
branch
from
ccfa0a0
to
98c5bc1
Compare
|
Maybe a better approach to find the latest version would be to implement something like: https://github.com/microsoft/vswhere/blob/f078b21784b53dd811ad72f0334b7b70f22aa9cf/src/vswhere.lib/InstanceSelector.cpp#L34 |
|
Thanks for this! I agree though yeah if we're doing comparisons we should probably do some pattern matching here, because otherwise I think this is doing lexicographical ordering which isn't numerical ordering? (or semver ordering) |
On windows, I have both MSVC 15 and 16 and found out that find_vs_version returns MSVC 16 while find_tool returns MSVC 15 linker.
Speedy37
force-pushed
the
fix-msvc-version
branch
from
98c5bc1
to
a2920da
Compare
|
I now convert installation version to Vec for the ordering. |
|
Nice! |
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 9, 2020
Pulls in updated MSVC detection logic landed in rust-lang/cc-rs#488
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
May 10, 2020
Pulls in updated MSVC detection logic landed in rust-lang/cc-rs#488
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 10, 2020
…lacrum Update the `cc` crate Pulls in updated MSVC detection logic landed in rust-lang/cc-rs#488
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 10, 2020
…lacrum Update the `cc` crate Pulls in updated MSVC detection logic landed in rust-lang/cc-rs#488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my PC, I have both MSVC 15 and 16 and found out that find_vs_version returns MSVC 16 while find_tool return MSVC 15 linker.
This caused rust to use MSVC 15 linker, while cmake generated file where made with MSVC 16.