Use Result as a replacement for ControlFlow in Visitor
#646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #648) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
LeSeulArtichaut
force-pushed
the
visitor-result
branch
from
6c98b6a
to
a9dc61c
Compare
|
Gonna close this in favor of #645. Thanks anyways @LeSeulArtichaut for writing an alternative implementation here. Overall, it's a neat idea, but I think the simple approach is probably better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (almost) resolves one of the differences between rustc's
TypeVisitorand chalk'sVisitorby adopting rustc's design withstd::ops::ControlFlow.Supersedes #645 with another approach suggested by @jackh726: instead of defining an
enum ControlFlow, define a type aliastype ControlFlow = Result, which allows to use?instead of a custom macro.