Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler-builtins emits a lof of warnings about conflicts method name #391

Closed
JohnTitor opened this issue Oct 27, 2020 · 4 comments
Closed

Comments

@JohnTitor
Copy link
Member

We can see a lot of warnings when building compiler-builtins:

 warning: a method with this name may be added to the standard library in the future
   --> /home/runner/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/compiler_builtins-0.1.35/src/int/udiv.rs:98:23
    |
98  |             q = n << (<$ty>::BITS - sr);
    |                       ^^^^^^^^^^^
...
268 |         udivmod_inner!(n, d, rem, u128)
    |         ------------------------------- in this macro invocation
    |
    = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <rust-lang/rust/issues/48919>
    = help: call with fully qualified syntax `Int::BITS(...)` to keep using the current method
    = help: add `#![feature(int_bits_const)]` to the crate attributes to enable `num::<impl u128>::BITS`
    = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

The problem is the same name item is added by rust-lang/rust#76492. It'd be great if we could tweak (rename or call them more specifically) code here to remove this warning :)

@AaronKutch
Copy link
Contributor

I have fixed this in PR #384, just need to get it merged

@AaronKutch
Copy link
Contributor

fixed on master now

@JohnTitor
Copy link
Member Author

Awesome!

@Amanieu Would you mind making a new release?

@Amanieu
Copy link
Member

Amanieu commented Dec 9, 2020

Done.

@Amanieu Amanieu closed this as completed Dec 9, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 12, 2020
Update `compiler_builtins` to 0.1.38

This version contains the fixes of rust-lang/compiler-builtins#390 and rust-lang/compiler-builtins#391.
Also, rename features following rust-lang/compiler-builtins#386.
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 7, 2021
Update `compiler_builtins` to 0.1.39

This version contains the fixes of rust-lang/compiler-builtins#390 and rust-lang/compiler-builtins#391.
Also, rename features following rust-lang/compiler-builtins#386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants