expose some math to UEFI envs #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it should be easy to port |
|
there already was an attempt to do it - #262 , but unfortunately it was reverted. So maybe later =) |
|
Can you rebase on the latest master to fix the CI failure (fixed in #437)? |
|
ok |
jackpot51
pushed a commit
to redox-os/uefi
that referenced
this pull request
Apr 9, 2022
Some math functions are exposed through compiler-builtins on newer releases. Fixes building system76/firmware-setup with new toolchain. Ref: rust-lang/compiler-builtins#435 Signed-off-by: Tim Crawford <tcrawford@system76.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #434
this was a bit tricky cause I had to use this workaround #388 (comment) for testing (also rename
__fltusedin my sources since it doesn't get mangled). Tested on a sample with math for UEFI and on a project for WASM; seems to be working =).So the diff is simple: just expose several math-functions for x86_64/uefi environments. The remaining functions produces undefined reference to
truncdfsf2(#327).