Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable f128 -> f16 tests on Linux #631

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jun 22, 2024

Since updating the docker images in #625, it looks like __extendhftf2 and __trunctfhf2 are available on all 64-bit Linux platforms.

@tgross35 tgross35 changed the title See if any new tests got fixed Enable f128 -> f16 tests on Linux Jun 22, 2024
@tgross35 tgross35 force-pushed the try-enabling-tests branch 2 times, most recently from b7d1f19 to 0be6054 Compare June 22, 2024 19:26
@tgross35 tgross35 marked this pull request as ready for review June 22, 2024 19:29
@@ -37,13 +37,10 @@ fn main() {
features.insert(Feature::NoSysF16F128Convert);
}

if target.starts_with("i586") || target.starts_with("i686") {
if target.starts_with("i586") {
// 32-bit x86 seems to not have `__fixunstfti`, but does have everything else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fixed for i586 as well now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it, looks like they are still not available on i586. I updated the note to mention this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why this function is available on i686 but not i586: they should be using the exact same docker image and toolchain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, think I figured it out - i586 and i686 are both missing __fixunstfti and __fixtfti. i686 was just always disabled at https://github.com/rust-lang/compiler-builtins/pull/631/files#diff-05ae0211bd995d6870067db299c32944cf2b743226442889bb07d48232afc2c5L26 because it has a f128 math bug, https://github.com/rust-lang/compiler-builtins/actions/runs/9640552090/job/26584543080?pr=631#step:13:244.

i586 probably also has that bug, but float tests without sse2 have been disabled since at least #384

#[cfg(not(all(target_arch = "x86", not(target_feature = "sse"))))]
mod float_addsub {
use super::*;
float_sum! {
f32, __addsf3, __subsf3, Single, all();
f64, __adddf3, __subdf3, Double, all();
}
}
#[cfg(not(feature = "no-f16-f128"))]
#[cfg(not(all(target_arch = "x86", not(target_feature = "sse"))))]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
mod float_addsub_f128 {
use super::*;
float_sum! {
f128, __addtf3, __subtf3, Quad, not(feature = "no-sys-f128");
}
}

@tgross35 tgross35 force-pushed the try-enabling-tests branch 2 times, most recently from 40d1f29 to f91f194 Compare June 24, 2024 06:25
Since updating the docker images in
<rust-lang#625>, it looks like
`__extendhftf2` and `__trunctfhf2` are available on all 64-bit Linux
platforms.
@Amanieu Amanieu enabled auto-merge June 25, 2024 21:57
@Amanieu Amanieu merged commit 7a84ce4 into rust-lang:master Jun 25, 2024
24 checks passed
@tgross35 tgross35 deleted the try-enabling-tests branch June 25, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants