Re-enable math module on i686-unknown-uefi #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YtvwlD
force-pushed
the
math-i686-uefi
branch
from
a09b363 to
e879b36
Compare
tgross35
reviewed
Oct 21, 2024
|
Thanks for the fix, one nit and then lgtm |
In 9ba77d1, this was disabled for x86 without sse2. It should be fine to re-enable it for UEFI, as explained at <rust-lang/rust#128533 (comment)>.
YtvwlD
force-pushed
the
math-i686-uefi
branch
from
e879b36 to
3dbc1ee
Compare
|
Thanks, you can open a PR bumping rust-lang/rust to 0.1.135 as soon as #716 merges. |
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Oct 26, 2024
This includes: * The license change rust-lang/compiler-builtins#717 * The `libm` submodule update, which also has a license change rust-lang/libm#317 * Re-enabling `math` on i686 UEFI rust-lang/compiler-builtins#715
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2024
Update compiler-builtins to 0.1.136 This includes: * The license change rust-lang/compiler-builtins#717 * The `libm` submodule update, which also has a license change rust-lang/libm#317 * Re-enabling `math` on i686 UEFI rust-lang/compiler-builtins#715 Fixes: rust-lang#128533
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Nov 1, 2024
This includes: * The license change rust-lang/compiler-builtins#717 * The `libm` submodule update, which also has a license change rust-lang/libm#317 * Re-enabling `math` on i686 UEFI rust-lang/compiler-builtins#715
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 1, 2024
Update compiler-builtins to 0.1.136 This includes: * The license change rust-lang/compiler-builtins#717 * The `libm` submodule update, which also has a license change rust-lang/libm#317 * Re-enabling `math` on i686 UEFI rust-lang/compiler-builtins#715 Fixes: rust-lang/rust#128533
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Nov 2, 2024
Update compiler-builtins to 0.1.136 This includes: * The license change rust-lang/compiler-builtins#717 * The `libm` submodule update, which also has a license change rust-lang/libm#317 * Re-enabling `math` on i686 UEFI rust-lang/compiler-builtins#715 Fixes: rust-lang/rust#128533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9ba77d1, this was disabled for x86 without sse2. It should be fine to re-enable it for UEFI, as explained at rust-lang/rust#128533 (comment).